[jira] [Commented] (HBASE-4562) When split doing offlineParentInMeta encounters error, it'll cause data loss

["stack (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126115#comment-13126115 ] 

stack commented on HBASE-4562:
------------------------------

I'm +1 on this patch if tests pass.  Its more conservative than what we currently have.  Comments in code speculated that we should probably tend to the more conservative.  Thanks for making the change bluedavy.
                
> When split doing offlineParentInMeta encounters error, it'll cause data loss
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-4562
>                 URL: https://issues.apache.org/jira/browse/HBASE-4562
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4
>            Reporter: bluedavy
>            Priority: Blocker
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4562-test.report.txt, HBASE-4562.patch, HBASE-4562for0.92.patch, HBASE-4562fortrunk.patch
>
>
> Follow below steps to replay the problem:
> 1. change the SplitTransaction.java as below,just like mock the timeout error.
>    {code:title=SplitTransaction.java|borderStyle=solid}
>       if (!testing) {
>         MetaEditor.offlineParentInMeta(server.getCatalogTracker(),
>            this.parent.getRegionInfo(), a.getRegionInfo(), b.getRegionInfo());
>         throw new IOException("some unexpected error in split");
>       }
>    {code} 
> 2. update the regionserver code,restart;
> 3. create a table & put some data to the table;
> 4. split the table;
> 5. kill the regionserver hosted the table;
> 6. wait some time after master ServerShutdownHandler.process execute,then scan the table,u'll find the data wrote before lost.
> We can fix the bug just use the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira