You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/06/27 19:51:57 UTC

[GitHub] [incubator-pinot] buchireddy commented on issue #4362: Optimize MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API

buchireddy commented on issue #4362: Optimize MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API
URL: https://github.com/apache/incubator-pinot/pull/4362#issuecomment-506486500
 
 
   > @sunithabeeram @buchireddy Added the benchmark number, and the performance difference is quite huge
   
   @Jackie-Jiang I'm assuming the lower the score is, the better it is and the results definitely look promising. Does this benchmarking consider the GC latencies as well? Like I mentioned above, batch copying seems to duplicate the buffers so you definitely need to analyze how could the buffer duplication impact the application.
   
   Thanks for the benchmarking though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org