You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2015/10/25 21:58:19 UTC
Review Request 39633: Remove Connection interface
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39633/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
The Connection interface is not used and can be safely removed.
Diffs
-----
commons/src/main/java/org/apache/aurora/common/net/pool/Connection.java 9309c118b7fc0bae6e5d58f33493d8229d9bff89
Diff: https://reviews.apache.org/r/39633/diff/
Testing
-------
./gradlew build -Pq
Thanks,
Zameer Manji
Re: Review Request 39633: Remove Connection interface
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39633/#review103968
-----------------------------------------------------------
Ship it!
Master (7c25ef9) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 25, 2015, 8:58 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39633/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2015, 8:58 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The Connection interface is not used and can be safely removed.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/net/pool/Connection.java 9309c118b7fc0bae6e5d58f33493d8229d9bff89
>
> Diff: https://reviews.apache.org/r/39633/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 39633: Remove Connection interface
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39633/#review103970
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Oct. 25, 2015, 1:58 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39633/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2015, 1:58 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The Connection interface is not used and can be safely removed.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/net/pool/Connection.java 9309c118b7fc0bae6e5d58f33493d8229d9bff89
>
> Diff: https://reviews.apache.org/r/39633/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>