You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by stigsb <gi...@git.apache.org> on 2014/11/26 17:50:43 UTC

[GitHub] thrift pull request: JSON generator: output complete descriptors

GitHub user stigsb opened a pull request:

    https://github.com/apache/thrift/pull/290

    JSON generator: output complete descriptors

    The attached pull request contains some improvements to the JSON generator:
    1. programs are no longer merged by default, use "--gen json:merge"
    2. "index" is renamed to "key" for fields to match the compiler's internal naming
    3. types are described in a way that does not require string parsing
    4. full support for exceptions, unions, namespaces, includes and required/optional fields
    
    Jira: THRIFT-2859


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stigsb/thrift THRIFT-2859

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #290
    
----
commit f111a95b177697b5a661a6de858d34521e352ada
Author: Stig Bakken <st...@zedge.net>
Date:   2014-10-31T08:04:14Z

    Add --gen json:merge option, and disable merging by default

commit 83109883d73d287a74a6b2a9800b6b299983ba40
Author: Stig Bakken <st...@zedge.net>
Date:   2014-11-03T08:08:21Z

    JSON generator: output complete descriptors

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: JSON generator: output complete descriptors

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/290


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---