You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by pengcheng xiong <px...@hortonworks.com> on 2016/09/21 18:01:46 UTC
Review Request 52127: Support UDTF in CBO (AST return path)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52127/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
HIVE-14806
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableFunctionScan.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java 9f5e733
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java 911b86b
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java e2ddb14
Diff: https://reviews.apache.org/r/52127/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 52127: Support UDTF in CBO (AST return path)
Posted by pengcheng xiong <px...@hortonworks.com>.
> On Sept. 29, 2016, 5:09 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java, line 3256
> > <https://reviews.apache.org/r/52127/diff/1/?file=1507482#file1507482line3256>
> >
> > Does this mean we won't support lateral view explode? That's one of the most used udtfs.
CBO does not support LV.
- pengcheng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52127/#review150863
-----------------------------------------------------------
On Sept. 21, 2016, 6:01 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52127/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2016, 6:01 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14806
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableFunctionScan.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java 9f5e733
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java 911b86b
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java e2ddb14
>
> Diff: https://reviews.apache.org/r/52127/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 52127: Support UDTF in CBO (AST return path)
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52127/#review150863
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java (line 278)
<https://reviews.apache.org/r/52127/#comment218951>
This function belongs in ASTConverter with private visibility.
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 3026)
<https://reviews.apache.org/r/52127/#comment218941>
isUDTF boolean is redundant. Can be replaced with genericUDTF != null.
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 3037)
<https://reviews.apache.org/r/52127/#comment218942>
LOG.debug
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 3041)
<https://reviews.apache.org/r/52127/#comment218939>
isUDTF is always true here. Can get rid of it.
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 3074)
<https://reviews.apache.org/r/52127/#comment218943>
throw Exception
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 3077)
<https://reviews.apache.org/r/52127/#comment218940>
no need for isDebugEnabled(), instead use {} within debug()
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 3256)
<https://reviews.apache.org/r/52127/#comment218948>
Does this mean we won't support lateral view explode? That's one of the most used udtfs.
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 3334)
<https://reviews.apache.org/r/52127/#comment218950>
whitespace.
- Ashutosh Chauhan
On Sept. 21, 2016, 6:01 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52127/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2016, 6:01 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14806
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableFunctionScan.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java 9f5e733
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java 911b86b
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java e2ddb14
>
> Diff: https://reviews.apache.org/r/52127/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 52127: Support UDTF in CBO (AST return path)
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52127/
-----------------------------------------------------------
(Updated Sept. 29, 2016, 9:37 p.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
HIVE-14806
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableFunctionScan.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java 9f5e733
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java 911b86b
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java e2ddb14
ql/src/test/results/clientpositive/allcolref_in_udf.q.out eda49ed
ql/src/test/results/clientpositive/lateral_view_noalias.q.out 7c08b86
ql/src/test/results/clientpositive/ppd_udtf.q.out 544b80e
ql/src/test/results/clientpositive/udf_inline.q.out f986abf
ql/src/test/results/clientpositive/udtf_explode.q.out de7a2f7
ql/src/test/results/clientpositive/udtf_json_tuple.q.out e0d4f00
ql/src/test/results/clientpositive/udtf_parse_url_tuple.q.out ad5ea21
Diff: https://reviews.apache.org/r/52127/diff/
Testing
-------
Thanks,
pengcheng xiong