You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Jeremy Daggett <no...@github.com> on 2014/06/06 20:49:12 UTC
[jclouds] Improve Expect Test readability (#397)
This PR improves the readability of misconfigured requests in Expect style tests.
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds fix-request-config-output
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/397
-- Commit Summary --
* Improve readability of expect test output
-- File Changes --
M core/src/test/java/org/jclouds/rest/internal/BaseRestApiExpectTest.java (9)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/397.patch
https://github.com/jclouds/jclouds/pull/397.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/397
Re: [jclouds] Improve Expect Test readability (#397)
Posted by Andrew Phillips <no...@github.com>.
> Is that a policy or something you can link us to for that?
I asked based on the idea that our `@apache.org` addresses includes the ASF ID, which is ultimately the unique identifier by which we are known to the foundation, is granted access rights to the repos etc. But you're absolutely right, @everett-toews: let me go and see whether there's a concrete policy specification something, and otherwise ask.
Just in case there was a misunderstanding: I was referring to the committer ID only, not to the author ID. I certainly want to ensure we give correct attribution (both individual and corporate) for contributions!
So please ignore for now - apologies for any confusion, @jdaggett!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/397#issuecomment-46038618
Re: [jclouds] Improve Expect Test readability (#397)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #864](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/864/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/397#issuecomment-45374381
Re: [jclouds] Improve Expect Test readability (#397)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #1192](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1192/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/397#issuecomment-45376473
Re: [jclouds] Improve Expect Test readability (#397)
Posted by Jeremy Daggett <no...@github.com>.
@demobox Its definitely a great question and I don't recall reading anything in the Committer's Guide about it. Based on what @andrewgaul just mentioned, I believe that we should use our `@apache.org` addresses as well. Next commit, how's that? ;)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/397#issuecomment-46056517
Re: [jclouds] Improve Expect Test readability (#397)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1335](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1335/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/397#issuecomment-45374584
Re: [jclouds] Improve Expect Test readability (#397)
Posted by Andrew Gaul <no...@github.com>.
I prefer that all committers to use their apache.org email addresses since they represent the project first and their employers second when working on jclouds.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/397#issuecomment-46055497
Re: [jclouds] Improve Expect Test readability (#397)
Posted by Everett Toews <no...@github.com>.
I strongly disagree with this. We have enough trouble attracting committers as it is. By making this a policy we're throwing up a barrier to contributors becoming committers.
I was at the Texas Linux Fest this weekend and I asked Karen Sandler, Lawyer and Executive Director of Software Freedom Conservancy (a FOSS foundation), about this. The answer (of course) was "It depends." Among other things, it depends on the company that is employing the committer. That company may have a very strong policy about what email address gets used on commits. Just because a committer may come from a company with such a policy, doesn't mean that we should automatically exclude them.
We need to look into the future and consider the consequences of our actions before making preference a policy.
This is not about Rackspace. Rackspace is very open source centric and very committed to upstream projects. Committers are able to use their discretion for what email addresses they use on commits. My personal preference is to use my Rackspace email address because they pay me to work on open source and I'm proud about that.
This is not about intellectual property (AFAIK). The email address used in no way imparts any IP ownership.
I've read nothing on [1] and [2] that requires a committer to use their @apache.org.
If requiring an @apache.org email in commits is not mandated by the ASF, it should not be mandated by jclouds.
This is not a conversation that belongs in a pull request. I'll email the our dev list to get more visibility on it.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/397#issuecomment-46192797
Re: [jclouds] Improve Expect Test readability (#397)
Posted by Zack Shoylev <no...@github.com>.
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/397#issuecomment-45790429
Re: [jclouds] Improve Expect Test readability (#397)
Posted by Andrew Phillips <no...@github.com>.
@jdaggett: It looks like this has [been merged](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=446671a2a7433f201b87f40e4d9960d80aa1f804)?
Also, please set up your GitHub repo to use your `@apache.org` address as the committer email? Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/397#issuecomment-45972870
Re: [jclouds] Improve Expect Test readability (#397)
Posted by Everett Toews <no...@github.com>.
@demobox Why are you asking @jdaggett to use his apache.org email address? Is that a policy or something you can link us to for that?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/397#issuecomment-46023777
Re: [jclouds] Improve Expect Test readability (#397)
Posted by Andrew Phillips <no...@github.com>.
> Next commit, how's that? ;)
That sounds like a plan! I've also [updated the Committer's Guide](https://wiki.apache.org/jclouds/Committers%20Guide?action=diff) to read "Ensure your name and @apache.org email address are there as the committer..."
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/397#issuecomment-46059631
Re: [jclouds] Improve Expect Test readability (#397)
Posted by Everett Toews <no...@github.com>.
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/397#issuecomment-45378137
Re: [jclouds] Improve Expect Test readability (#397)
Posted by Jeremy Daggett <no...@github.com>.
Closed #397.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/397#event-131827944