You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "xushiyan (via GitHub)" <gi...@apache.org> on 2025/01/04 21:50:27 UTC
[PR] refactor: improve `TimelineSelector` API [hudi-rs]
xushiyan opened a new pull request, #234:
URL: https://github.com/apache/hudi-rs/pull/234
## Description
<!--- Describe your changes in detail -->
Make `TimelineSelector` API easier to use for loading instants.
<!--- If it fixes an open issue, please link to the issue here. -->
<!--- Please link any related issues and PRs as well. -->
## How are the changes test-covered
- [ ] N/A
- [ ] Automated tests (unit and/or integration tests)
- [ ] Manual tests
- [ ] Details are described below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: improve `TimelineSelector` API [hudi-rs]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #234:
URL: https://github.com/apache/hudi-rs/pull/234#issuecomment-2571421509
## [Codecov](https://app.codecov.io/gh/apache/hudi-rs/pull/234?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `90.00000%` with `6 lines` in your changes missing coverage. Please review.
> Project coverage is 91.76%. Comparing base [(`f02cabf`)](https://app.codecov.io/gh/apache/hudi-rs/commit/f02cabfee4985cf9609690d70c852bb9fb9c0cd6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`c2a69fa`)](https://app.codecov.io/gh/apache/hudi-rs/commit/c2a69faa229f804aff8c6ad525491033b841fc3a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi-rs/pull/234?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [crates/core/src/timeline/mod.rs](https://app.codecov.io/gh/apache/hudi-rs/pull/234?src=pr&el=tree&filepath=crates%2Fcore%2Fsrc%2Ftimeline%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3JhdGVzL2NvcmUvc3JjL3RpbWVsaW5lL21vZC5ycw==) | 81.25% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi-rs/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [crates/core/src/timeline/selector.rs](https://app.codecov.io/gh/apache/hudi-rs/pull/234?src=pr&el=tree&filepath=crates%2Fcore%2Fsrc%2Ftimeline%2Fselector.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3JhdGVzL2NvcmUvc3JjL3RpbWVsaW5lL3NlbGVjdG9yLnJz) | 91.89% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi-rs/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 91.67% 91.76% +0.09%
==========================================
Files 26 26
Lines 1225 1239 +14
==========================================
+ Hits 1123 1137 +14
Misses 102 102
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/hudi-rs/pull/234?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: improve `TimelineSelector` API [hudi-rs]
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan merged PR #234:
URL: https://github.com/apache/hudi-rs/pull/234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org