You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by dcelasun <gi...@git.apache.org> on 2017/06/02 12:39:22 UTC

[GitHub] thrift pull request #1285: THRIFT-4215/4216 Make transport factories return ...

GitHub user dcelasun opened a pull request:

    https://github.com/apache/thrift/pull/1285

    THRIFT-4215/4216 Make transport factories return errors

    This commit changes the signature of `TTransportFactory.GetTransport` from
    ```go
    GetTransport(trans TTransport) TTransport
    ```
    to
    ```go
    GetTransport(trans TTransport) (TTransport, error)
    ```
    so the factory can pass any underlying error to the caller (previously such errors were ignored).
    
    This is a backwards incompatible change for anyone implementing custom transports, but it shouldn't effect anyone using the ones in this library.
    
    Fixes [THRIFT-4215](https://issues.apache.org/jira/browse/THRIFT-4215).
    
    Fixes [THRIFT-4216](https://issues.apache.org/jira/browse/THRIFT-4216).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dcelasun/thrift THRIFT-4215

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1285.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1285
    
----
commit 312a4aadbb2106c9fb21360b87e0c2d5fea8a78e
Author: D. Can Celasun <ca...@dcc.im>
Date:   2017-06-02T12:33:32Z

    THRIFT-4215 Make transport factories return errors
    
    This commit changes the signature of TTransportFactory.GetTransport
    from
    
      GetTransport(trans TTransport) TTransport
    
    to
    
      GetTransport(trans TTransport) (TTransport, error)
    
    so the factory can pass any underlying error to the caller (previously
    such errors were ignored).
    
    This is a backwards incompatible change for anyone implementing custom
    transports, but it shouldn't effect anyone using the ones in this
    library.
    
    Fixes THRIFT-4215.
    
    Fixes THRIFT-4216.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1285: THRIFT-4215/4216 Make transport factories return errors

Posted by dcelasun <gi...@git.apache.org>.

Github user dcelasun commented on the issue:

    https://github.com/apache/thrift/pull/1285
  
    Closing PR until all tests are fixed, I don't want to waste Apache's Travis capacity.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1285: THRIFT-4215/4216 Make transport factories return ...

Posted by dcelasun <gi...@git.apache.org>.

Github user dcelasun closed the pull request at:

    https://github.com/apache/thrift/pull/1285


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1285: THRIFT-4215/4216 Make transport factories return errors

Posted by dcelasun <gi...@git.apache.org>.

Github user dcelasun commented on the issue:

    https://github.com/apache/thrift/pull/1285
  
    Yes sorry about that, this was an expected breakage as the interface has changed. I suggest using `0.10` instead of `master`, that way you won't get any surprises like this until `0.11` is released.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1285: THRIFT-4215/4216 Make transport factories return errors

Posted by peterbourgon <gi...@git.apache.org>.

Github user peterbourgon commented on the issue:

    https://github.com/apache/thrift/pull/1285
  
    For the record, this caused build failures in Go kit; I don't imagine my usage is particularly strange, but maybe it is. ([Link](https://github.com/go-kit/kit/commit/4d3c82de4829f7c3752cf66d00d6ecdf913a18f3).)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---