[GitHub] nicolaferraro commented on a change in pull request #357: kamel stuck when a secret has an illegal name

[GitBox <gi...@apache.org>]

nicolaferraro commented on a change in pull request #357: kamel stuck when a secret has an illegal name
URL: https://github.com/apache/camel-k/pull/357#discussion_r250219058
 
 

 ##########
 File path: pkg/trait/deployment.go
 ##########
 @@ -418,7 +419,8 @@ func (t *deploymentTrait) getDeploymentFor(e *Environment) *appsv1.Deployment {
 	//
 
 	VisitConfigurations("configmap", e.Context, e.Integration, func(cmName string) {
-		refName := "integration-cm-" + strings.ToLower(cmName)
+		refName := xid.New().String()
 
 Review comment:
   We don't reconcile when subresources change, but if we start doing it in the future, this creates problems as it's random. Wdyt @lburgazzoli ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services