You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@syncope.apache.org by re...@apache.org on 2012/05/04 17:02:19 UTC

svn commit: r1334010 - /incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/pages/panels/ResourcesPanel.java

Author: rene
Date: Fri May  4 15:02:19 2012
New Revision: 1334010

URL: http://svn.apache.org/viewvc?rev=1334010&view=rev
Log:
sonar: example fix of serializable inner class problem

Modified:
    incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/pages/panels/ResourcesPanel.java

Modified: incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/pages/panels/ResourcesPanel.java
URL: http://svn.apache.org/viewvc/incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/pages/panels/ResourcesPanel.java?rev=1334010&r1=1334009&r2=1334010&view=diff
==============================================================================
--- incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/pages/panels/ResourcesPanel.java (original)
+++ incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/pages/panels/ResourcesPanel.java Fri May  4 15:02:19 2012
@@ -38,27 +38,33 @@ public class ResourcesPanel extends Pane
     @SpringBean
     private ResourceRestClient resourceRestClient;
 
-    final IModel<List<String>> allResources = new LoadableDetachableModel<List<String>>() {
+    public <T extends AbstractAttributableTO> ResourcesPanel(final String id, final T entityTO) {
+        super(id);
+        final IModel<List<String>> allResources = new allResourcesModel(resourceRestClient);
+
+        final AjaxPalettePanel resourcesPalette = new AjaxPalettePanel("resourcesPalette", new PropertyModel(entityTO,
+                "resources"), new ListModel<String>(allResources.getObject()));
 
+        add(resourcesPalette);
+    }
+    
+    private static class allResourcesModel extends LoadableDetachableModel {
         private static final long serialVersionUID = 5275935387613157437L;
 
+        private ResourceRestClient client;
+        
+        public allResourcesModel(ResourceRestClient resourceRestClient) {
+            this.client = resourceRestClient;
+        }
+
         @Override
-        protected List<String> load() {
+        protected Object load() {
             final List<String> resourceNames = new ArrayList<String>();
 
-            for (ResourceTO resourceTO : resourceRestClient.getAllResources()) {
+            for (ResourceTO resourceTO : client.getAllResources()) {
                 resourceNames.add(resourceTO.getName());
             }
             return resourceNames;
         }
-    };
-
-    public <T extends AbstractAttributableTO> ResourcesPanel(final String id, final T entityTO) {
-        super(id);
-
-        final AjaxPalettePanel resourcesPalette = new AjaxPalettePanel("resourcesPalette", new PropertyModel(entityTO,
-                "resources"), new ListModel<String>(allResources.getObject()));
-
-        add(resourcesPalette);
     }
 }