You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/10 17:41:16 UTC
[GitHub] [superset] Antonio-RiveroMartnez opened a new pull request, #22665: fix(toast): Fix the way we import Interweave
Antonio-RiveroMartnez opened a new pull request, #22665:
URL: https://github.com/apache/superset/pull/22665
### SUMMARY
- Fix the way we import Interweave so it doesn't break our toasts
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
### TESTING INSTRUCTIONS
1. Open DB modal and test a connection
2. Create a DB
3. Delete the DB
All those operations should render the toast with no issues instead of the blank page we are getting now
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Antonio-RiveroMartnez commented on pull request #22665: fix(toast): Fix the way we import Interweave
Posted by GitBox <gi...@apache.org>.
Antonio-RiveroMartnez commented on PR #22665:
URL: https://github.com/apache/superset/pull/22665#issuecomment-1377677365
Closing this PR because the bug was present only because I was under the old version of Interweave. Now that I've updated it, it's all good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Antonio-RiveroMartnez closed pull request #22665: fix(toast): Fix the way we import Interweave
Posted by GitBox <gi...@apache.org>.
Antonio-RiveroMartnez closed pull request #22665: fix(toast): Fix the way we import Interweave
URL: https://github.com/apache/superset/pull/22665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org