You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Marcel Reutegger (JIRA)" <ji...@apache.org> on 2015/02/26 14:58:04 UTC

[jira] [Commented] (OAK-2548) Spellcheck/suggest queries should return no results if no index can handle them

    [ https://issues.apache.org/jira/browse/OAK-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338403#comment-14338403 ] 

Marcel Reutegger commented on OAK-2548:
---------------------------------------

This commit causes test failures in oak-core:

{noformat}
Tests in error: 
  sql1(org.apache.jackrabbit.oak.plugins.index.property.OrderedIndexQueryTest): Results in target/sql1.txt don't match expected results in src/test/resources/sql1.txt; compare the files for details
  sql1(org.apache.jackrabbit.oak.plugins.index.property.PropertyIndexQueryTest): Results in target/sql1.txt don't match expected results in src/test/resources/sql1.txt; compare the files for details
  sql1(org.apache.jackrabbit.oak.query.index.TraversingIndexQueryTest): Results in target/sql1.txt don't match expected results in src/test/resources/sql1.txt; compare the files for details
{noformat}

> Spellcheck/suggest queries should return no results if no index can handle them
> -------------------------------------------------------------------------------
>
>                 Key: OAK-2548
>                 URL: https://issues.apache.org/jira/browse/OAK-2548
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: query
>            Reporter: Tommaso Teofili
>            Assignee: Tommaso Teofili
>             Fix For: 1.1.7
>
>
> Spellcheck/suggest queries currently fail if no {{FulltextIndex}} that can handle them (via native language support), throwing an Exception
> {noformat}
>  java.lang.IllegalArgumentException: No full-text index was found that can process the condition spellcheck([a], 'foo')
> {noformat}
> However I'd suggest (:P) that they would silently return no rows by changing {{SpellcheckImpl#evaluate}} and {{SuggestImpl#evaluate}} to return _false_ in such cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)