You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/21 18:08:49 UTC

[GitHub] [incubator-druid] abossert opened a new pull request #8364: Removed hard-coded Kafka Deserializer in Web-UI

abossert opened a new pull request #8364: Removed hard-coded Kafka Deserializer in Web-UI
URL: https://github.com/apache/incubator-druid/pull/8364
 
 
   # Description
   I had originally submitted a pull request that allowed for custom Kafka deserializers to be used with the Kafka indexing service.  After that merge completed, I noticed that in the data-ingest UI for Kafka in the new console, the Kafka sampler was still hard-coded with the ByteArrayDeserializer, so I have additionally removed the hard-coded value such that if the user does not supply a custom deserializer, the "old" behavior will still apply (e.g. default to ByteArrayDeserializer), but if the user specifies a custom deserializer in the consumer properties, it will be honored.
   
   # Key changed/added classes in this PR
    * `org.apache.druid.indexing.kafka.KafkaSamplerSpec`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org