You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/12 06:08:00 UTC
[jira] [Commented] (FLINK-7161) Fix misusage of Double.MIN_VALUE
and Float.MIN_VALUE
[ https://issues.apache.org/jira/browse/FLINK-7161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083493#comment-16083493 ]
ASF GitHub Bot commented on FLINK-7161:
---------------------------------------
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/4305
[FLINK-7161] fix misusage of Float.MIN_VALUE and Double.MIN_VALUE
I already checked all places using Float.MIN_VALUE and Double.MIN_VALUE and fixed all misusage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/KurtYoung/flink flink-7161
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4305.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4305
----
commit 5c7a2fd4c97eaedba87b0042e337d94f315b4191
Author: Kurt Young <yk...@gmail.com>
Date: 2017-07-12T06:02:58Z
[FLINK-7161] fix misusage of Float.MIN_VALUE and Double.MIN_VALUE
----
> Fix misusage of Double.MIN_VALUE and Float.MIN_VALUE
> ----------------------------------------------------
>
> Key: FLINK-7161
> URL: https://issues.apache.org/jira/browse/FLINK-7161
> Project: Flink
> Issue Type: Bug
> Affects Versions: 1.3.1
> Reporter: Kurt Young
> Assignee: Kurt Young
>
> In FloatSummaryAggregator and DoubleSummaryAggregator, we used Float.MIN_VALUE and Double.MIN_VALUE to be the initial values when doing max aggregation which is wrong.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)