You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/02/18 17:15:07 UTC
Review Request: SQOOP-439: Released artifacts should embrace unwritten
naming policy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3949/
-----------------------------------------------------------
Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
Summary
-------
I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases.
I've tried to use AntCall (http://ant.apache.org/manual/Tasks/antcall.html) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time.
I'll update wiki page "How to Release" in case that this patch will be accepted.
This addresses bug SQOOP-439.
https://issues.apache.org/jira/browse/SQOOP-439
Diffs
-----
/build.xml 1245157
Diff: https://reviews.apache.org/r/3949/diff
Testing
-------
ant srctar
ant tar
- Inside generated artifacts both "ant test" and "ant releaseaudit"
Thanks,
Jarek
Re: Review Request: SQOOP-439: Released artifacts should embrace unwritten
naming policy
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3949/#review5257
-----------------------------------------------------------
Ship it!
Look good overall. Just one minor suggestion below.
/build.xml
<https://reviews.apache.org/r/3949/#comment11474>
value="${artifact.name}"
- Bilung
On 2012-02-18 16:15:07, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3949/
> -----------------------------------------------------------
>
> (Updated 2012-02-18 16:15:07)
>
>
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
>
>
> Summary
> -------
>
> I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases.
>
> I've tried to use AntCall (http://ant.apache.org/manual/Tasks/antcall.html) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time.
>
> I'll update wiki page "How to Release" in case that this patch will be accepted.
>
>
> This addresses bug SQOOP-439.
> https://issues.apache.org/jira/browse/SQOOP-439
>
>
> Diffs
> -----
>
> /build.xml 1245157
>
> Diff: https://reviews.apache.org/r/3949/diff
>
>
> Testing
> -------
>
> ant srctar
> ant tar
> - Inside generated artifacts both "ant test" and "ant releaseaudit"
>
>
> Thanks,
>
> Jarek
>
>
Re: Review Request: SQOOP-439: Released artifacts should embrace unwritten
naming policy
Posted by Jarek Cecho <ja...@apache.org>.
> On 2012-02-22 19:41:46, Bilung Lee wrote:
> > +1
Thank you very much for your review sir. I've already uploaded updated patch to JIRA, so please feel free to commit it in.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3949/#review5289
-----------------------------------------------------------
On 2012-02-22 08:01:10, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3949/
> -----------------------------------------------------------
>
> (Updated 2012-02-22 08:01:10)
>
>
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
>
>
> Summary
> -------
>
> I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases.
>
> I've tried to use AntCall (http://ant.apache.org/manual/Tasks/antcall.html) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time.
>
> I'll update wiki page "How to Release" in case that this patch will be accepted.
>
>
> This addresses bug SQOOP-439.
> https://issues.apache.org/jira/browse/SQOOP-439
>
>
> Diffs
> -----
>
> /build.xml 1292137
>
> Diff: https://reviews.apache.org/r/3949/diff
>
>
> Testing
> -------
>
> ant srctar
> ant tar
> - Inside generated artifacts both "ant test" and "ant releaseaudit"
>
>
> Thanks,
>
> Jarek
>
>
Re: Review Request: SQOOP-439: Released artifacts should embrace unwritten
naming policy
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3949/#review5289
-----------------------------------------------------------
Ship it!
+1
- Bilung
On 2012-02-22 08:01:10, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3949/
> -----------------------------------------------------------
>
> (Updated 2012-02-22 08:01:10)
>
>
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
>
>
> Summary
> -------
>
> I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases.
>
> I've tried to use AntCall (http://ant.apache.org/manual/Tasks/antcall.html) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time.
>
> I'll update wiki page "How to Release" in case that this patch will be accepted.
>
>
> This addresses bug SQOOP-439.
> https://issues.apache.org/jira/browse/SQOOP-439
>
>
> Diffs
> -----
>
> /build.xml 1292137
>
> Diff: https://reviews.apache.org/r/3949/diff
>
>
> Testing
> -------
>
> ant srctar
> ant tar
> - Inside generated artifacts both "ant test" and "ant releaseaudit"
>
>
> Thanks,
>
> Jarek
>
>
Re: Review Request: SQOOP-439: Released artifacts should embrace unwritten
naming policy
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3949/
-----------------------------------------------------------
(Updated 2012-02-22 08:01:10.675913)
Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
Changes
-------
Applied Bilung's suggestion.
Summary
-------
I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases.
I've tried to use AntCall (http://ant.apache.org/manual/Tasks/antcall.html) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time.
I'll update wiki page "How to Release" in case that this patch will be accepted.
This addresses bug SQOOP-439.
https://issues.apache.org/jira/browse/SQOOP-439
Diffs (updated)
-----
/build.xml 1292137
Diff: https://reviews.apache.org/r/3949/diff
Testing
-------
ant srctar
ant tar
- Inside generated artifacts both "ant test" and "ant releaseaudit"
Thanks,
Jarek