You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/02 04:45:05 UTC
[GitHub] [incubator-superset] bearcage commented on a change in pull request
#7422: [WIP] Add "validation_only" queries to the backend
bearcage commented on a change in pull request #7422: [WIP] Add "validation_only" queries to the backend
URL: https://github.com/apache/incubator-superset/pull/7422#discussion_r280287944
##########
File path: superset/views/core.py
##########
@@ -2528,6 +2530,43 @@ def sql_json(self):
json_error_response(
'Database with id {} is missing.'.format(database_id))
+ # Validation request.
+ if validate_only:
Review comment:
No particular reason, apart from an instinct to try to minimize the changeset — I'm happy to pull it out if you'd prefer it that way!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org