You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dpogue <gi...@git.apache.org> on 2017/04/21 07:19:18 UTC
[GitHub] cordova-android pull request #377: CB-8980: Ensure copied resource-files are...
GitHub user dpogue opened a pull request:
https://github.com/apache/cordova-android/pull/377
CB-8980: Ensure copied resource-files are cleaned
Requires https://github.com/apache/cordova-lib/pull/547 for the intended functionality, but is safe to merge even without it.
Addresses the point 1 of https://github.com/apache/cordova-android/pull/321#issuecomment-294985346 where `resource-file` targets were not getting cleaned.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpogue/cordova-android resource-file-clean
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/377.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #377
----
commit 318d113c93291e88febcc7f44ca87b677c078ae2
Author: Darryl Pogue <da...@dpogue.ca>
Date: 2017-04-21T07:18:16Z
CB-8980: Ensure copied resource-files are cleaned
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #377: CB-8980: Ensure copied resource-files are...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/377
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #377: CB-8980: Ensure copied resource-files are cleane...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/377
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/377?src=pr&el=h1) Report
> Merging [#377](https://codecov.io/gh/apache/cordova-android/pull/377?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/e13e15d3e9aa4b9a61c6ece434e7c023fa5c3553?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/377?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 42.07% 42.07%
=======================================
Files 14 14
Lines 1338 1338
Branches 245 245
=======================================
Hits 563 563
Misses 775 775
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/377?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/377?src=pr&el=footer). Last update [e13e15d...318d113](https://codecov.io/gh/apache/cordova-android/pull/377?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org