You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/02/06 07:51:07 UTC
[jira] Created: (HBASE-414) Move client classes into client package
Move client classes into client package
---------------------------------------
Key: HBASE-414
URL: https://issues.apache.org/jira/browse/HBASE-414
Project: Hadoop HBase
Issue Type: Sub-task
Reporter: Bryan Duxbury
Assignee: Bryan Duxbury
Priority: Minor
Fix For: 0.2.0
Let's move all the client classes into the o.a.h.h.client package.
Files to move:
* HTable
* HBaseAdmin
* HConnection
* HConnectionManager
Is there anything else I am missing? Obviously a lot of the tests will get moved too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-414) Move client classes into client package
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HBASE-414:
--------------------------------
Component/s: test
> Move client classes into client package
> ---------------------------------------
>
> Key: HBASE-414
> URL: https://issues.apache.org/jira/browse/HBASE-414
> Project: Hadoop HBase
> Issue Type: Sub-task
> Components: test
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2.0
>
>
> Let's move all the client classes into the o.a.h.h.client package.
> Files to move:
> * HTable
> * HBaseAdmin
> * HConnection
> * HConnectionManager
> Is there anything else I am missing? Obviously a lot of the tests will get moved too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-414) Move client classes into client package
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HBASE-414:
--------------------------------
Component/s: (was: test)
client
> Move client classes into client package
> ---------------------------------------
>
> Key: HBASE-414
> URL: https://issues.apache.org/jira/browse/HBASE-414
> Project: Hadoop HBase
> Issue Type: Sub-task
> Components: client
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2.0
>
>
> Let's move all the client classes into the o.a.h.h.client package.
> Files to move:
> * HTable
> * HBaseAdmin
> * HConnection
> * HConnectionManager
> Is there anything else I am missing? Obviously a lot of the tests will get moved too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-414) Move client classes into client
package
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568778#action_12568778 ]
Bryan Duxbury commented on HBASE-414:
-------------------------------------
... or you learn about the -E switch on patch. That's cool too.
> Move client classes into client package
> ---------------------------------------
>
> Key: HBASE-414
> URL: https://issues.apache.org/jira/browse/HBASE-414
> Project: Hadoop HBase
> Issue Type: Sub-task
> Components: client
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: 414.patch
>
>
> Let's move all the client classes into the o.a.h.h.client package.
> Files to move:
> * HTable
> * HBaseAdmin
> * HConnection
> * HConnectionManager
> Is there anything else I am missing? Obviously a lot of the tests will get moved too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-414) Move client classes into client
package
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569143#action_12569143 ]
Jim Kellerman commented on HBASE-414:
-------------------------------------
Applied patch and ran tests which passed. +1
> Move client classes into client package
> ---------------------------------------
>
> Key: HBASE-414
> URL: https://issues.apache.org/jira/browse/HBASE-414
> Project: Hadoop HBase
> Issue Type: Sub-task
> Components: client
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: 414.patch
>
>
> Let's move all the client classes into the o.a.h.h.client package.
> Files to move:
> * HTable
> * HBaseAdmin
> * HConnection
> * HConnectionManager
> Is there anything else I am missing? Obviously a lot of the tests will get moved too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-414) Move client classes into client package
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HBASE-414:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this.
> Move client classes into client package
> ---------------------------------------
>
> Key: HBASE-414
> URL: https://issues.apache.org/jira/browse/HBASE-414
> Project: Hadoop HBase
> Issue Type: Sub-task
> Components: client
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: 414.patch
>
>
> Let's move all the client classes into the o.a.h.h.client package.
> Files to move:
> * HTable
> * HBaseAdmin
> * HConnection
> * HConnectionManager
> Is there anything else I am missing? Obviously a lot of the tests will get moved too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-414) Move client classes into client package
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HBASE-414:
--------------------------------
Status: Patch Available (was: In Progress)
Please review.
> Move client classes into client package
> ---------------------------------------
>
> Key: HBASE-414
> URL: https://issues.apache.org/jira/browse/HBASE-414
> Project: Hadoop HBase
> Issue Type: Sub-task
> Components: client
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: 414.patch
>
>
> Let's move all the client classes into the o.a.h.h.client package.
> Files to move:
> * HTable
> * HBaseAdmin
> * HConnection
> * HConnectionManager
> Is there anything else I am missing? Obviously a lot of the tests will get moved too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-414) Move client classes into client
package
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568769#action_12568769 ]
Bryan Duxbury commented on HBASE-414:
-------------------------------------
Do you know a way to have svn diff include deletes and adds?
> Move client classes into client package
> ---------------------------------------
>
> Key: HBASE-414
> URL: https://issues.apache.org/jira/browse/HBASE-414
> Project: Hadoop HBase
> Issue Type: Sub-task
> Components: client
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: 414.patch
>
>
> Let's move all the client classes into the o.a.h.h.client package.
> Files to move:
> * HTable
> * HBaseAdmin
> * HConnection
> * HConnectionManager
> Is there anything else I am missing? Obviously a lot of the tests will get moved too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (HBASE-414) Move client classes into client
package
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HBASE-414 started by Bryan Duxbury.
> Move client classes into client package
> ---------------------------------------
>
> Key: HBASE-414
> URL: https://issues.apache.org/jira/browse/HBASE-414
> Project: Hadoop HBase
> Issue Type: Sub-task
> Components: client
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2.0
>
>
> Let's move all the client classes into the o.a.h.h.client package.
> Files to move:
> * HTable
> * HBaseAdmin
> * HConnection
> * HConnectionManager
> Is there anything else I am missing? Obviously a lot of the tests will get moved too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-414) Move client classes into client package
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HBASE-414:
--------------------------------
Attachment: 414.patch
Here's a patch that moves everything around. To apply, delete:
* src/test/org/apache/hadoop/hbase/TestBatchUpdate.java
* src/test/org/apache/hadoop/hbase/TestHTable.java
* src/test/org/apache/hadoop/hbase/TestListTables.java
* src/test/org/apache/hadoop/hbase/TestMultipleUpdates.java
* src/java/org/apache/hadoop/hbase/HConnectionManager.java
* src/java/org/apache/hadoop/hbase/HConnection.java
* src/java/org/apache/hadoop/hbase/HBaseAdmin.java
* src/java/org/apache/hadoop/hbase/HTable.java
then apply the patch, which will create new (moved) versions of the deleted files, which contain edits, so it's not just a simple move.
Tests pass locally.
> Move client classes into client package
> ---------------------------------------
>
> Key: HBASE-414
> URL: https://issues.apache.org/jira/browse/HBASE-414
> Project: Hadoop HBase
> Issue Type: Sub-task
> Components: client
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: 414.patch
>
>
> Let's move all the client classes into the o.a.h.h.client package.
> Files to move:
> * HTable
> * HBaseAdmin
> * HConnection
> * HConnectionManager
> Is there anything else I am missing? Obviously a lot of the tests will get moved too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-414) Move client classes into client
package
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568772#action_12568772 ]
Jim Kellerman commented on HBASE-414:
-------------------------------------
To get adds, you need to do svn add filename before svn diff.
To get deletes, you need to do svn {delete|del|remove|rm} before doing svn diff
> Move client classes into client package
> ---------------------------------------
>
> Key: HBASE-414
> URL: https://issues.apache.org/jira/browse/HBASE-414
> Project: Hadoop HBase
> Issue Type: Sub-task
> Components: client
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: 414.patch
>
>
> Let's move all the client classes into the o.a.h.h.client package.
> Files to move:
> * HTable
> * HBaseAdmin
> * HConnection
> * HConnectionManager
> Is there anything else I am missing? Obviously a lot of the tests will get moved too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-414) Move client classes into client
package
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568775#action_12568775 ]
Bryan Duxbury commented on HBASE-414:
-------------------------------------
I've already done that. The .patch file does not contain whatever information is necessary to tell svn to delete the deleted files. You have to do that manually.
> Move client classes into client package
> ---------------------------------------
>
> Key: HBASE-414
> URL: https://issues.apache.org/jira/browse/HBASE-414
> Project: Hadoop HBase
> Issue Type: Sub-task
> Components: client
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: 414.patch
>
>
> Let's move all the client classes into the o.a.h.h.client package.
> Files to move:
> * HTable
> * HBaseAdmin
> * HConnection
> * HConnectionManager
> Is there anything else I am missing? Obviously a lot of the tests will get moved too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-414) Move client classes into client
package
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568767#action_12568767 ]
Jim Kellerman commented on HBASE-414:
-------------------------------------
So why doesn't the patch have the deletes in it?
> Move client classes into client package
> ---------------------------------------
>
> Key: HBASE-414
> URL: https://issues.apache.org/jira/browse/HBASE-414
> Project: Hadoop HBase
> Issue Type: Sub-task
> Components: client
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: 414.patch
>
>
> Let's move all the client classes into the o.a.h.h.client package.
> Files to move:
> * HTable
> * HBaseAdmin
> * HConnection
> * HConnectionManager
> Is there anything else I am missing? Obviously a lot of the tests will get moved too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.