[GitHub] [accumulo-testing] ctubbsii commented on a diff in pull request #232: Update README Accumulo update instructions

[GitBox <gi...@apache.org>]

ctubbsii commented on code in PR #232:
URL: https://github.com/apache/accumulo-testing/pull/232#discussion_r983728863


##########
contrib/terraform-testing-infrastructure/README.md:
##########
@@ -356,8 +356,14 @@ doing the following and then restarting Accumulo:
 ```bash
 cd ${software_root}/sources/accumulo-repo
 git pull
-mvn -s ${software_root}/apache-maven/settings.xml clean package -DskipTests -DskipITs
+mvn clean package -DskipTests -DskipITs
+# Backup the Accumulo configs
+mkdir -p ~/backup
+cp ${software_root}/accumulo/accumulo-${accumulo_version}/conf/* ~/backup/.

Review Comment:
   "backup" is such a generic name. What if this directory already exists and contains other things? I know these are just example instructions, but users are likely just going to copy/paste these. It may be useful to select a more targeted/unique name in these instructions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org