You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by jr...@apache.org on 2017/11/13 22:11:23 UTC
[2/6] incubator-impala git commit: IMPALA-6170: Remove broken backend
test from llvm-codegen-test
IMPALA-6170: Remove broken backend test from llvm-codegen-test
Remove backend test that expects hdfs service to be running, which is
not an expectation backend test should have. This caused test runs to
fail that use the local filesystem as their default filesystem.
Also the code path exercised by that test is already covered in the end
to end tests, like in test_udfs.py for cases where the functions used in
the query live in the same lib file.
Change-Id: Iaed0109f5163343427015d571d6d24233b9d3fdc
Reviewed-on: http://gerrit.cloudera.org:8080/8505
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/5ab07f03
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/5ab07f03
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/5ab07f03
Branch: refs/heads/master
Commit: 5ab07f032941537755a3d8bc8e58caa6c8ac8233
Parents: 3a1073c
Author: Bikramjeet Vig <bi...@cloudera.com>
Authored: Wed Nov 8 13:59:46 2017 -0800
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Fri Nov 10 01:21:45 2017 +0000
----------------------------------------------------------------------
be/src/codegen/llvm-codegen-test.cc | 11 -----------
1 file changed, 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/5ab07f03/be/src/codegen/llvm-codegen-test.cc
----------------------------------------------------------------------
diff --git a/be/src/codegen/llvm-codegen-test.cc b/be/src/codegen/llvm-codegen-test.cc
index e42b041..68a5ff8 100644
--- a/be/src/codegen/llvm-codegen-test.cc
+++ b/be/src/codegen/llvm-codegen-test.cc
@@ -479,17 +479,6 @@ TEST_F(LlvmCodeGenTest, HandleLinkageError) {
codegen->Close();
}
-// Test that Impala does not return error when trying to link the same lib file twice.
-TEST_F(LlvmCodeGenTest, LinkageTest) {
- scoped_ptr<LlvmCodeGen> codegen;
- ASSERT_OK(LlvmCodeGen::CreateImpalaCodegen(runtime_state_, nullptr, "test", &codegen));
- EXPECT_TRUE(codegen.get() != nullptr);
- string hdfs_file_path("/test-warehouse/test-udfs.ll");
- ASSERT_OK(LinkModuleFromHdfs(codegen.get(), hdfs_file_path));
- ASSERT_OK(LinkModuleFromHdfs(codegen.get(), hdfs_file_path));
- codegen->Close();
-}
-
}
int main(int argc, char **argv) {