You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by iv...@apache.org on 2014/02/21 08:37:31 UTC
[06/31] git commit: WICKET-3335 Add some TODOs
WICKET-3335 Add some TODOs
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/7729de43
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/7729de43
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/7729de43
Branch: refs/heads/master
Commit: 7729de431bc7d480b7e10cea515e02b98edace2f
Parents: 58558e7
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Mon Feb 10 14:13:28 2014 +0200
Committer: Igor Vaynberg <ig...@gmail.com>
Committed: Thu Feb 20 23:37:14 2014 -0800
----------------------------------------------------------------------
wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java | 3 +++
.../java/org/apache/wicket/queueing/ComponentQueueingTest.java | 4 +++-
2 files changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/7729de43/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java b/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java
index 2db19b2..19b72aa 100644
--- a/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java
+++ b/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java
@@ -941,6 +941,7 @@ public abstract class MarkupContainer extends Component implements Iterable<Comp
cursor = cursor.getParent();
}
+ // TODO WICKET-3335: queueRegion is always non-null if page is non-null
if (queueRegion != null && page != null)
{
if (!queueRegion.dequeuing)
@@ -2008,6 +2009,7 @@ public abstract class MarkupContainer extends Component implements Iterable<Comp
if (queue != null && !queue.isEmpty())
{
+ // TODO WICKET-3335: Print the queue ?!
throw new WicketRuntimeException("Detach called on component: " + getId()
+ " while it had a non-empty queue");
}
@@ -2044,6 +2046,7 @@ public abstract class MarkupContainer extends Component implements Iterable<Comp
if (page != null)
{
+ // TODO WICKET-3335: should we check if (!region.dequeueing) ?
region.dequeue();
}
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/7729de43/wicket-core/src/test/java/org/apache/wicket/queueing/ComponentQueueingTest.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/test/java/org/apache/wicket/queueing/ComponentQueueingTest.java b/wicket-core/src/test/java/org/apache/wicket/queueing/ComponentQueueingTest.java
index cda2e30..175a8d6 100644
--- a/wicket-core/src/test/java/org/apache/wicket/queueing/ComponentQueueingTest.java
+++ b/wicket-core/src/test/java/org/apache/wicket/queueing/ComponentQueueingTest.java
@@ -136,7 +136,9 @@ public class ComponentQueueingTest extends WicketTestCase
assertThat(p, hasPath(new Path(a, c)));
}
- /** {@code [a,b,c] -> [a[b,c]] } */
+ /** {@code [a,b,c] -> [a[b,c]] }
+ * TODO WICKET-3335 Fix the javadoc above
+ * */
@Test
public void dequeue7()
{