You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/10 01:38:30 UTC
[GitHub] [airflow] kaxil opened a new pull request #7121: [AIRFLOW-6526]
Remove unused line in k8s worker_configuration.py
kaxil opened a new pull request #7121: [AIRFLOW-6526] Remove unused line in k8s worker_configuration.py
URL: https://github.com/apache/airflow/pull/7121
This line is not used anywhere.
Let me know if we want to add a
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7121: [AIRFLOW-6526]
Remove unused line in k8s worker_configuration.py
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7121: [AIRFLOW-6526] Remove unused line in k8s worker_configuration.py
URL: https://github.com/apache/airflow/pull/7121#issuecomment-572843916
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7121?src=pr&el=h1) Report
> Merging [#7121](https://codecov.io/gh/apache/airflow/pull/7121?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5491f4d40413075d85b50f39c27ad871741c68d8?src=pr&el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7121?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7121 +/- ##
==========================================
- Coverage 85.24% 85.02% -0.22%
==========================================
Files 682 683 +1
Lines 39096 39151 +55
==========================================
- Hits 33327 33288 -39
- Misses 5769 5863 +94
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7121?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/worker\_configuration.py](https://codecov.io/gh/apache/airflow/pull/7121/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3dvcmtlcl9jb25maWd1cmF0aW9uLnB5) | `99.28% <ø> (-0.01%)` | :arrow_down: |
| [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/7121/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7121/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7121/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `90% <0%> (-6.67%)` | :arrow_down: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7121/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `76.02% <0%> (-1.54%)` | :arrow_down: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7121/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `67.8% <0%> (-0.98%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7121/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `90.9% <0%> (-0.83%)` | :arrow_down: |
| [airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7121/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5) | `85.52% <0%> (-0.44%)` | :arrow_down: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7121/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.07% <0%> (-0.13%)` | :arrow_down: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7121/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.86% <0%> (-0.03%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7121/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7121?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7121?src=pr&el=footer). Last update [5491f4d...56347be](https://codecov.io/gh/apache/airflow/pull/7121?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] dimberman merged pull request #7121: [AIRFLOW-6526]
Remove unused line in k8s worker_configuration.py
Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #7121: [AIRFLOW-6526] Remove unused line in k8s worker_configuration.py
URL: https://github.com/apache/airflow/pull/7121
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7121:
[AIRFLOW-6526] Remove unused line in k8s worker_configuration.py
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7121: [AIRFLOW-6526] Remove unused line in k8s worker_configuration.py
URL: https://github.com/apache/airflow/pull/7121#issuecomment-572843916
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7121?src=pr&el=h1) Report
> Merging [#7121](https://codecov.io/gh/apache/airflow/pull/7121?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5491f4d40413075d85b50f39c27ad871741c68d8?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7121?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7121 +/- ##
==========================================
+ Coverage 85.24% 85.24% +<.01%
==========================================
Files 682 683 +1
Lines 39096 39151 +55
==========================================
+ Hits 33327 33374 +47
- Misses 5769 5777 +8
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7121?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/worker\_configuration.py](https://codecov.io/gh/apache/airflow/pull/7121/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3dvcmtlcl9jb25maWd1cmF0aW9uLnB5) | `99.28% <ø> (-0.01%)` | :arrow_down: |
| [airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7121/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5) | `85.52% <0%> (-0.44%)` | :arrow_down: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7121/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.07% <0%> (-0.13%)` | :arrow_down: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7121/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.86% <0%> (-0.03%)` | :arrow_down: |
| [...w/example\_dags/example\_external\_task\_marker\_dag.py](https://codecov.io/gh/apache/airflow/pull/7121/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9leHRlcm5hbF90YXNrX21hcmtlcl9kYWcucHk=) | `100% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7121?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7121?src=pr&el=footer). Last update [5491f4d...56347be](https://codecov.io/gh/apache/airflow/pull/7121?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services