You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/08/28 21:46:46 UTC

Review Request 68550: Fixed flakiness in the `CreateDestroyDiskRecovery` SLRP test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68550/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Greg Mann, and Jie Yu.


Repository: mesos


Description
-------

Fixed flakiness in the `CreateDestroyDiskRecovery` SLRP test.


Diffs
-----

  src/tests/storage_local_resource_provider_tests.cpp 997154a8f6c30b7d74ff5e67fb3efa0bc2b94de7 


Diff: https://reviews.apache.org/r/68550/diff/1/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Re: Review Request 68550: Fixed flakiness in the `CreateDestroyDiskRecovery` SLRP test.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68550/#review208073
-----------------------------------------------------------



PASS: Mesos patch 68550 was successfully built and tested.

Reviews applied: `['68550']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2254/mesos-review-68550

- Mesos Reviewbot Windows


On Aug. 28, 2018, 9:46 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68550/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2018, 9:46 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Greg Mann, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed flakiness in the `CreateDestroyDiskRecovery` SLRP test.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 997154a8f6c30b7d74ff5e67fb3efa0bc2b94de7 
> 
> 
> Diff: https://reviews.apache.org/r/68550/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 68550: Fixed flakiness in the `CreateDestroyDiskRecovery` SLRP test.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68550/#review208072
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Aug. 28, 2018, 9:46 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68550/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2018, 9:46 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Greg Mann, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed flakiness in the `CreateDestroyDiskRecovery` SLRP test.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 997154a8f6c30b7d74ff5e67fb3efa0bc2b94de7 
> 
> 
> Diff: https://reviews.apache.org/r/68550/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>