You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org> on 2016/09/19 21:55:20 UTC
[kudu-CR] Separated Dead and Live tablet server count in master web ui.
Ninad Shringarpure has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4450
Change subject: Separated Dead and Live tablet server count in master web ui.
......................................................................
Separated Dead and Live tablet server count in master web ui.
Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
---
M src/kudu/master/master-path-handlers.cc
1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/1
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Posted by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4450
to look at the new patch set (#6).
Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
......................................................................
[web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Creating two lists of tservers live and dead.
Created a function to generate html tables taking server list and table header as params.
Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
---
M src/kudu/master/master-path-handlers.cc
1 file changed, 25 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/6
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
......................................................................
[web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Creating two lists of tservers live and dead.
Created a function to generate html tables taking server list and table header as params.
Attached sampe screenshot:
https://github.com/ninadshr/sample_repo/blob/master/tablet_servers.png
Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Reviewed-on: http://gerrit.cloudera.org:8080/4450
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/master/master-path-handlers.cc
1 file changed, 25 insertions(+), 12 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 13
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
......................................................................
Patch Set 10:
(2 comments)
Almost there, just 2 style nits are left.
http://gerrit.cloudera.org:8080/#/c/4450/10/src/kudu/master/master-path-handlers.cc
File src/kudu/master/master-path-handlers.cc:
Line 114: *output << "<table class='table table-striped'>\n";
style nit: it seems lines 114-117 contain tabs. The Kudu project uses google's C++ style guide which prescribes using 2 spaces as indent for inter-scope lines: https://google.github.io/styleguide/cppguide.html#Spaces_vs._Tabs
PS10, Line 118:
nit: an extra indent is needed to be in balance with the opening brace of the if() block.
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
......................................................................
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Separated Dead and Live tablet server count in master web ui.
Posted by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org>.
Ninad Shringarpure has restored this change.
Change subject: Separated Dead and Live tablet server count in master web ui.
......................................................................
Restored
Made the required change and comiting the patch.
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: restore
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Posted by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4450
to look at the new patch set (#5).
Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
......................................................................
[web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
---
M src/kudu/master/master-path-handlers.cc
1 file changed, 27 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/5
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Posted by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4450
to look at the new patch set (#12).
Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
......................................................................
[web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Creating two lists of tservers live and dead.
Created a function to generate html tables taking server list and table header as params.
Attached sampe screenshot:
https://github.com/ninadshr/sample_repo/blob/master/tablet_servers.png
Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
---
M src/kudu/master/master-path-handlers.cc
1 file changed, 25 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/12
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Posted by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4450
to look at the new patch set (#3).
Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
......................................................................
[web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
---
M src/kudu/master/master-path-handlers.cc
1 file changed, 27 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/3
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
......................................................................
Patch Set 11:
(1 comment)
oops, missed one extra nit in previous reviews. Otherwise looks good!
http://gerrit.cloudera.org:8080/#/c/4450/11/src/kudu/master/master-path-handlers.cc
File src/kudu/master/master-path-handlers.cc:
PS11, Line 85:
nit: an extra indent. It would be nice to have lines 85, 86, and 87 to be aligned with the first parameter after the opening parenthesis (i.e. like it was in the original code). I somehow missed that in earlier reviews, I apologize.
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4450/5/src/kudu/master/master-path-handlers.cc
File src/kudu/master/master-path-handlers.cc:
PS5, Line 111: if (!live_tserver_rows.empty()) {
: *output << "<h4>Live Tablet Servers</h4>\n";
: *output << "<table class='table table-striped'>\n";
: *output << "<tr><th>UUID</th><th>Time since heartbeat</th><th>Registration</th></tr>\n";
: *output << JoinStrings(live_tserver_rows, "\n");
: *output << "</table>\n";
: }
Consider making a function out of it (e.g., a lambda function) and re-using it for generating both tables.
Something like
auto generate_table = [](const vector<string>& rows,
const string& header,
ostream* output) {
if (!rows.empty()) {
*output << "<h4>" << header << "</h4>\n";
*output << "<table class='table table-striped'>\n";
*output << "<tr><th>UUID</th><th>Time since heartbeat</th><th>Registration</th></tr>\n";
*output << JoinStrings(rows, "\n");
*output << "</table>\n";
}
};
generate_table(live_tserver_rows, "Live Tablet Servers", output);
generate_table(dead_tserver_rows, "Dead Tablet Servers", output);
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Posted by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4450
to look at the new patch set (#11).
Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
......................................................................
[web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Creating two lists of tservers live and dead.
Created a function to generate html tables taking server list and table header as params.
Attached sampe screenshot:
https://github.com/ninadshr/sample_repo/blob/master/tablet_servers.png
Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
---
M src/kudu/master/master-path-handlers.cc
1 file changed, 24 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/11
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Separated Dead and Live tablet server count in master web ui.
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Separated Dead and Live tablet server count in master web ui.
......................................................................
Patch Set 1:
hmm, were you looking at KUDU-1619? I think the intention here was to separate the tables which list the tablet servers into two sections, not the "version summary" at the top.
Also, would be good to mention the JIRA in the commit message (see how other commits in the git log refer to JIRAs)
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Posted by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4450
to look at the new patch set (#8).
Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
......................................................................
[web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Creating two lists of tservers live and dead.
Created a function to generate html tables taking server list and table header as params.
Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
---
M src/kudu/master/master-path-handlers.cc
1 file changed, 24 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/8
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Posted by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4450
to look at the new patch set (#9).
Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
......................................................................
[web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Creating two lists of tservers live and dead.
Created a function to generate html tables taking server list and table header as params.
Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
---
M src/kudu/master/master-path-handlers.cc
1 file changed, 23 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/9
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
......................................................................
Patch Set 12: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Separated Dead and Live tablet server count in master web ui.
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Separated Dead and Live tablet server count in master web ui.
......................................................................
Patch Set 2:
Also, it seems like you've now got two reviews stacked on top of each other. Please use 'git rebase -i' to merge them into a single commit, and in the future use 'git commit --amend' to amend patches between revisions.
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Posted by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4450
to look at the new patch set (#4).
Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
......................................................................
[web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
---
M src/kudu/master/master-path-handlers.cc
1 file changed, 27 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/4
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
......................................................................
Patch Set 6:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4450/6/src/kudu/master/master-path-handlers.cc
File src/kudu/master/master-path-handlers.cc:
PS6, Line 109:
formatting nit: the second and third parameter lines are not aligned with the first. Consider making them aligned.
PS6, Line 111:
nit: by style guide, the indent is 2 spaces.
Line 121:
nit: an extra line
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Posted by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4450
to look at the new patch set (#10).
Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
......................................................................
[web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Creating two lists of tservers live and dead.
Created a function to generate html tables taking server list and table header as params.
Attached sampe screenshot:
https://github.com/ninadshr/sample_repo/blob/master/tablet_servers.png
Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
---
M src/kudu/master/master-path-handlers.cc
1 file changed, 24 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/10
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Posted by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4450
to look at the new patch set (#7).
Change subject: [web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
......................................................................
[web-ui] KUDU-1619 Separate tables for live and dead tservers on /tablet-servers
Creating two lists of tservers live and dead.
Created a function to generate html tables taking server list and table header as params.
Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/tserver/tserver-path-handlers.cc
2 files changed, 66 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/4450/7
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Separated Dead and Live tablet server count in master web ui.
Posted by "Ninad Shringarpure (Code Review)" <ge...@cloudera.org>.
Ninad Shringarpure has abandoned this change.
Change subject: Separated Dead and Live tablet server count in master web ui.
......................................................................
Abandoned
Missed a test case.
--
To view, visit http://gerrit.cloudera.org:8080/4450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I479fad5c2db61949f7d67bde7901e7a59c60b786
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot