You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by ma...@apache.org on 2017/10/19 03:27:48 UTC

[trafficserver] branch quic-latest updated: Add missed changes for the last commit

This is an automated email from the ASF dual-hosted git repository.

maskit pushed a commit to branch quic-latest
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/quic-latest by this push:
     new 843a7ca  Add missed changes for the last commit
843a7ca is described below

commit 843a7ca5f2369d474d114e8d0feefc572125374f
Author: Masakazu Kitajo <ma...@apache.org>
AuthorDate: Thu Oct 19 12:26:19 2017 +0900

    Add missed changes for the last commit
---
 iocore/net/QUICPacketHandler.cc | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/iocore/net/QUICPacketHandler.cc b/iocore/net/QUICPacketHandler.cc
index e86fed4..aff1f87 100644
--- a/iocore/net/QUICPacketHandler.cc
+++ b/iocore/net/QUICPacketHandler.cc
@@ -166,10 +166,15 @@ QUICPacketHandler::_recv_packet(int event, UDPPacket *udpPacket)
     this->action_->continuation->handleEvent(NET_EVENT_ACCEPT, vc);
   }
 
-  vc->push_packet(udpPacket);
-
-  // send to EThread
-  eventProcessor.schedule_imm(vc, ET_CALL, QUIC_EVENT_PACKET_READ_READY, nullptr);
+  if (vc->is_closed()) {
+    this->_connections.put(vc->connection_id(), nullptr);
+    // FIXME QUICNetVConnection is NOT freed to prevent crashes. #2674
+    // QUICNetVConnections are going to be freed by QUICNetHandler
+    // vc->free(vc->thread);
+  } else {
+    vc->push_packet(udpPacket);
+    eventProcessor.schedule_imm(vc, ET_CALL, QUIC_EVENT_PACKET_READ_READY, nullptr);
+  }
 }
 
 // TODO: Should be called via eventProcessor?
@@ -203,9 +208,3 @@ QUICPacketHandler::send_packet(const QUICPacket &packet, UDPConnection *udp_con,
 
   udp_con->send(this, udpPkt);
 }
-
-void
-QUICPacketHandler::forget(QUICNetVConnection *vc)
-{
-  this->_connections.put(vc->connection_id(), nullptr);
-}

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].