[GitHub] brodybits commented on issue #535: Fix user agent match issue android pie

[GitBox <gi...@apache.org>]

brodybits commented on issue #535: Fix user agent match issue android pie
URL: https://github.com/apache/cordova-android/pull/535#issuecomment-437399822
 
 
   Thanks for the contribution. Considering that `check` is only used to check for version range of 4.0...4.3 and minimum Android version is now 4.4 ([[1]](https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#requirements-and-support)) I would suggest a much simpler solution: simply remove the lines that check `check` and `version_code`, along with some of the comments above.
   
   Another note is that we generally use the `cordova-coho` tool to generate `bin/templates/project/assets/www/cordova.js`. I would prefer if that you remove the change to `bin/templates/project/assets/www/cordova.js` from this PR.
   
   [1] <https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#requirements-and-support>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org