You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2025/01/09 23:48:26 UTC

[ALL] CP 79 - 'Last Published' date not being updated correctly

It looks like the changes to CP 79 and the maven site setup have
broken the 'Last Published' date.

When I build with

$ mvn site -Psite-quick

For CP 79 I get

Last Published: 07 Jan 2025

For validator I get:

Last Published: 28 May 2024

Sebb

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [ALL] CP 79 - 'Last Published' date not being updated correctly

Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Jan 10, 2025, 17:54 sebb <se...@gmail.com> wrote:

> On Fri, 10 Jan 2025 at 22:34, Gary Gregory <ga...@gmail.com> wrote:
> >
> > On Fri, Jan 10, 2025 at 4:07 PM sebb <se...@gmail.com> wrote:
> > >
> > > On Fri, 10 Jan 2025 at 01:25, Gary Gregory <ga...@gmail.com>
> wrote:
> > > >
> > > > Hi Sebb,
> > > >
> > > > It's not a hack but the Maven way of providing reproducible builds as
> > > > documented here:
> > > > https://maven.apache.org/guides/mini/guide-reproducible-builds.html
> > >
> > > I see. Still seems like a hack to me.
> >
> > Well, ok, tell that to the Maven folk then ;-)
> >
> > >
> > > Presumably the date can be changed at some point?
> > > Perhaps on release?
> >
> > It is only changed by the tooling (Maven) during the release process.
> > I cut releases from a branch called "release", so, in the release
> > branch, the property is updated when Maven changes the version from a
> > -SNAPSHOT version to the release version by a command like:
> >
> > mvn versions:set -DnewVersion=1.2.3 -DgenerateBackupPoms=false
> >
> > For example:
> https://github.com/apache/commons-codec/commit/50dcf5053cc3eefba3447b718e014c1a3c4cd1de
>
> Seems to me that a SNAPSHOT pom should not include the property; it
> should only be added when necessary for the release.
>

Feel free to bring it up on the Maven list, I'm just working with what
Maven provides...

Gary


> > HTH,
> > Gary
> >
> > >
> > > A better solution might be to only add the property to the RC tag.
> > >
> > > Or the RM builds with a specific
> > > > HTH,
> > > > Gary
> > > >
> > > > On Thu, Jan 9, 2025 at 7:27 PM sebb <se...@gmail.com> wrote:
> > > > >
> > > > > I think I have found the issue:
> > > > >
> > > > > The parent and validator pom.xml files now contain a definition for
> > > > > the property:
> > > > >
> > > > > project.build.outputTimestamp
> > > > >
> > > > > This appears to be a hack related to reproducible builds.
> > > > > Whilst that is a worthwhile goal, I don't think that should be to
> the
> > > > > detriment of an accurate publication date.
> > > > >
> > > > > Sebb
> > > > >
> > > > > On Thu, 9 Jan 2025 at 23:48, sebb <se...@gmail.com> wrote:
> > > > > >
> > > > > > It looks like the changes to CP 79 and the maven site setup have
> > > > > > broken the 'Last Published' date.
> > > > > >
> > > > > > When I build with
> > > > > >
> > > > > > $ mvn site -Psite-quick
> > > > > >
> > > > > > For CP 79 I get
> > > > > >
> > > > > > Last Published: 07 Jan 2025
> > > > > >
> > > > > > For validator I get:
> > > > > >
> > > > > > Last Published: 28 May 2024
> > > > > >
> > > > > > Sebb
> > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > > > For additional commands, e-mail: dev-help@commons.apache.org
> > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > > For additional commands, e-mail: dev-help@commons.apache.org
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > For additional commands, e-mail: dev-help@commons.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Re: [ALL] CP 79 - 'Last Published' date not being updated correctly

Posted by sebb <se...@gmail.com>.
On Fri, 10 Jan 2025 at 22:34, Gary Gregory <ga...@gmail.com> wrote:
>
> On Fri, Jan 10, 2025 at 4:07 PM sebb <se...@gmail.com> wrote:
> >
> > On Fri, 10 Jan 2025 at 01:25, Gary Gregory <ga...@gmail.com> wrote:
> > >
> > > Hi Sebb,
> > >
> > > It's not a hack but the Maven way of providing reproducible builds as
> > > documented here:
> > > https://maven.apache.org/guides/mini/guide-reproducible-builds.html
> >
> > I see. Still seems like a hack to me.
>
> Well, ok, tell that to the Maven folk then ;-)
>
> >
> > Presumably the date can be changed at some point?
> > Perhaps on release?
>
> It is only changed by the tooling (Maven) during the release process.
> I cut releases from a branch called "release", so, in the release
> branch, the property is updated when Maven changes the version from a
> -SNAPSHOT version to the release version by a command like:
>
> mvn versions:set -DnewVersion=1.2.3 -DgenerateBackupPoms=false
>
> For example: https://github.com/apache/commons-codec/commit/50dcf5053cc3eefba3447b718e014c1a3c4cd1de

Seems to me that a SNAPSHOT pom should not include the property; it
should only be added when necessary for the release.

> HTH,
> Gary
>
> >
> > A better solution might be to only add the property to the RC tag.
> >
> > Or the RM builds with a specific
> > > HTH,
> > > Gary
> > >
> > > On Thu, Jan 9, 2025 at 7:27 PM sebb <se...@gmail.com> wrote:
> > > >
> > > > I think I have found the issue:
> > > >
> > > > The parent and validator pom.xml files now contain a definition for
> > > > the property:
> > > >
> > > > project.build.outputTimestamp
> > > >
> > > > This appears to be a hack related to reproducible builds.
> > > > Whilst that is a worthwhile goal, I don't think that should be to the
> > > > detriment of an accurate publication date.
> > > >
> > > > Sebb
> > > >
> > > > On Thu, 9 Jan 2025 at 23:48, sebb <se...@gmail.com> wrote:
> > > > >
> > > > > It looks like the changes to CP 79 and the maven site setup have
> > > > > broken the 'Last Published' date.
> > > > >
> > > > > When I build with
> > > > >
> > > > > $ mvn site -Psite-quick
> > > > >
> > > > > For CP 79 I get
> > > > >
> > > > > Last Published: 07 Jan 2025
> > > > >
> > > > > For validator I get:
> > > > >
> > > > > Last Published: 28 May 2024
> > > > >
> > > > > Sebb
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > > For additional commands, e-mail: dev-help@commons.apache.org
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > For additional commands, e-mail: dev-help@commons.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [ALL] CP 79 - 'Last Published' date not being updated correctly

Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Jan 10, 2025 at 4:07 PM sebb <se...@gmail.com> wrote:
>
> On Fri, 10 Jan 2025 at 01:25, Gary Gregory <ga...@gmail.com> wrote:
> >
> > Hi Sebb,
> >
> > It's not a hack but the Maven way of providing reproducible builds as
> > documented here:
> > https://maven.apache.org/guides/mini/guide-reproducible-builds.html
>
> I see. Still seems like a hack to me.

Well, ok, tell that to the Maven folk then ;-)

>
> Presumably the date can be changed at some point?
> Perhaps on release?

It is only changed by the tooling (Maven) during the release process.
I cut releases from a branch called "release", so, in the release
branch, the property is updated when Maven changes the version from a
-SNAPSHOT version to the release version by a command like:

mvn versions:set -DnewVersion=1.2.3 -DgenerateBackupPoms=false

For example: https://github.com/apache/commons-codec/commit/50dcf5053cc3eefba3447b718e014c1a3c4cd1de

HTH,
Gary

>
> A better solution might be to only add the property to the RC tag.
>
> Or the RM builds with a specific
> > HTH,
> > Gary
> >
> > On Thu, Jan 9, 2025 at 7:27 PM sebb <se...@gmail.com> wrote:
> > >
> > > I think I have found the issue:
> > >
> > > The parent and validator pom.xml files now contain a definition for
> > > the property:
> > >
> > > project.build.outputTimestamp
> > >
> > > This appears to be a hack related to reproducible builds.
> > > Whilst that is a worthwhile goal, I don't think that should be to the
> > > detriment of an accurate publication date.
> > >
> > > Sebb
> > >
> > > On Thu, 9 Jan 2025 at 23:48, sebb <se...@gmail.com> wrote:
> > > >
> > > > It looks like the changes to CP 79 and the maven site setup have
> > > > broken the 'Last Published' date.
> > > >
> > > > When I build with
> > > >
> > > > $ mvn site -Psite-quick
> > > >
> > > > For CP 79 I get
> > > >
> > > > Last Published: 07 Jan 2025
> > > >
> > > > For validator I get:
> > > >
> > > > Last Published: 28 May 2024
> > > >
> > > > Sebb
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > For additional commands, e-mail: dev-help@commons.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [ALL] CP 79 - 'Last Published' date not being updated correctly

Posted by sebb <se...@gmail.com>.
On Fri, 10 Jan 2025 at 01:25, Gary Gregory <ga...@gmail.com> wrote:
>
> Hi Sebb,
>
> It's not a hack but the Maven way of providing reproducible builds as
> documented here:
> https://maven.apache.org/guides/mini/guide-reproducible-builds.html

I see. Still seems like a hack to me.

Presumably the date can be changed at some point?
Perhaps on release?

A better solution might be to only add the property to the RC tag.

Or the RM builds with a specific
> HTH,
> Gary
>
> On Thu, Jan 9, 2025 at 7:27 PM sebb <se...@gmail.com> wrote:
> >
> > I think I have found the issue:
> >
> > The parent and validator pom.xml files now contain a definition for
> > the property:
> >
> > project.build.outputTimestamp
> >
> > This appears to be a hack related to reproducible builds.
> > Whilst that is a worthwhile goal, I don't think that should be to the
> > detriment of an accurate publication date.
> >
> > Sebb
> >
> > On Thu, 9 Jan 2025 at 23:48, sebb <se...@gmail.com> wrote:
> > >
> > > It looks like the changes to CP 79 and the maven site setup have
> > > broken the 'Last Published' date.
> > >
> > > When I build with
> > >
> > > $ mvn site -Psite-quick
> > >
> > > For CP 79 I get
> > >
> > > Last Published: 07 Jan 2025
> > >
> > > For validator I get:
> > >
> > > Last Published: 28 May 2024
> > >
> > > Sebb
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [ALL] CP 79 - 'Last Published' date not being updated correctly

Posted by Gary Gregory <ga...@gmail.com>.
Hi Sebb,

It's not a hack but the Maven way of providing reproducible builds as
documented here:
https://maven.apache.org/guides/mini/guide-reproducible-builds.html

HTH,
Gary

On Thu, Jan 9, 2025 at 7:27 PM sebb <se...@gmail.com> wrote:
>
> I think I have found the issue:
>
> The parent and validator pom.xml files now contain a definition for
> the property:
>
> project.build.outputTimestamp
>
> This appears to be a hack related to reproducible builds.
> Whilst that is a worthwhile goal, I don't think that should be to the
> detriment of an accurate publication date.
>
> Sebb
>
> On Thu, 9 Jan 2025 at 23:48, sebb <se...@gmail.com> wrote:
> >
> > It looks like the changes to CP 79 and the maven site setup have
> > broken the 'Last Published' date.
> >
> > When I build with
> >
> > $ mvn site -Psite-quick
> >
> > For CP 79 I get
> >
> > Last Published: 07 Jan 2025
> >
> > For validator I get:
> >
> > Last Published: 28 May 2024
> >
> > Sebb
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [ALL] CP 79 - 'Last Published' date not being updated correctly

Posted by sebb <se...@gmail.com>.
I think I have found the issue:

The parent and validator pom.xml files now contain a definition for
the property:

project.build.outputTimestamp

This appears to be a hack related to reproducible builds.
Whilst that is a worthwhile goal, I don't think that should be to the
detriment of an accurate publication date.

Sebb

On Thu, 9 Jan 2025 at 23:48, sebb <se...@gmail.com> wrote:
>
> It looks like the changes to CP 79 and the maven site setup have
> broken the 'Last Published' date.
>
> When I build with
>
> $ mvn site -Psite-quick
>
> For CP 79 I get
>
> Last Published: 07 Jan 2025
>
> For validator I get:
>
> Last Published: 28 May 2024
>
> Sebb

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org