You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2020/08/11 07:05:40 UTC
[royale-asjs] branch develop updated: jewel-renderers: fix issue
with renderers no dispatching dataChange after refactor
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 1f0c8b4 jewel-renderers: fix issue with renderers no dispatching dataChange after refactor
1f0c8b4 is described below
commit 1f0c8b431008bc2be02d3efa0cc04b71187f6d63
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Tue Aug 11 09:05:26 2020 +0200
jewel-renderers: fix issue with renderers no dispatching dataChange after refactor
---
.../org/apache/royale/jewel/itemRenderers/DataGridItemRenderer.as | 8 +++++++-
.../org/apache/royale/jewel/itemRenderers/ListItemRenderer.as | 7 ++++++-
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/DataGridItemRenderer.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/DataGridItemRenderer.as
index 10bd497..071b546 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/DataGridItemRenderer.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/DataGridItemRenderer.as
@@ -21,6 +21,7 @@ package org.apache.royale.jewel.itemRenderers
import org.apache.royale.core.IChild;
import org.apache.royale.core.ILabelFunction;
import org.apache.royale.core.IStrand;
+ import org.apache.royale.events.Event;
import org.apache.royale.html.util.getLabelFromData;
/**
@@ -75,7 +76,12 @@ package org.apache.royale.jewel.itemRenderers
text = labelFunctionBead.labelFunction(value, itemRendererOwnerView.host);
else
text = getLabelFromData(this, value);
- _data = value;
+
+ if (value != data)
+ {
+ _data = value;
+ dispatchEvent(new Event("dataChange"));
+ }
}
}
}
\ No newline at end of file
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/ListItemRenderer.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/ListItemRenderer.as
index 7f02d1c..3d8326a 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/ListItemRenderer.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/ListItemRenderer.as
@@ -142,7 +142,12 @@ package org.apache.royale.jewel.itemRenderers
text = labelFunctionBead.labelFunction(value);
else
text = getLabelFromData(this, value);
- _data = value;
+
+ if (value != data)
+ {
+ _data = value;
+ dispatchEvent(new Event("dataChange"));
+ }
}
/**