You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/09/26 00:40:03 UTC
Review Request 38779: Use new HTTP status code check in scheduler.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38779/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Ben Mahler.
Repository: mesos
Description
-------
Use new HTTP status code check in scheduler.
Diffs
-----
src/scheduler/scheduler.cpp ee146eb81a8ad72bc04c62d1e223de6aa27b351d
Diff: https://reviews.apache.org/r/38779/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 38779: Use new HTTP status code check in scheduler.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38779/#review101226
-----------------------------------------------------------
src/scheduler/scheduler.cpp (line 352)
<https://reviews.apache.org/r/38779/#comment158601>
Does the comments need to be updated? The "200 OK" is still here
src/scheduler/scheduler.cpp (line 373)
<https://reviews.apache.org/r/38779/#comment158602>
ditto
- Guangya Liu
On 九月 25, 2015, 10:40 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38779/
> -----------------------------------------------------------
>
> (Updated 九月 25, 2015, 10:40 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use new HTTP status code check in scheduler.
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp ee146eb81a8ad72bc04c62d1e223de6aa27b351d
>
> Diff: https://reviews.apache.org/r/38779/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 38779: Use new HTTP status code check in scheduler.
Posted by Gilbert Song <gi...@mesoshere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38779/#review101685
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Oct. 6, 2015, 1:27 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38779/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 1:27 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use new HTTP status code check in scheduler.
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp 56801ca6ffc9f9f0e4bd12dbf535e9c5251c2712
>
> Diff: https://reviews.apache.org/r/38779/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 38779: Use new HTTP status code check in scheduler.
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38779/#review103720
-----------------------------------------------------------
Ship it!
Ship It!
- Jian Qiu
On Oct. 23, 2015, 4:25 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38779/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 4:25 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use new HTTP status code check in scheduler.
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp 33e4d7cd0dfb3c4d4ef928707104034eff634ff1
>
> Diff: https://reviews.apache.org/r/38779/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 38779: Use new HTTP status code check in scheduler.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38779/#review103718
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38416, 38779]
All tests passed.
- Mesos ReviewBot
On Oct. 23, 2015, 4:25 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38779/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 4:25 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use new HTTP status code check in scheduler.
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp 33e4d7cd0dfb3c4d4ef928707104034eff634ff1
>
> Diff: https://reviews.apache.org/r/38779/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 38779: Use new HTTP status code check in scheduler.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38779/
-----------------------------------------------------------
(Updated Oct. 23, 2015, 4:25 a.m.)
Review request for mesos, Anand Mazumdar and Ben Mahler.
Repository: mesos
Description
-------
Use new HTTP status code check in scheduler.
Diffs (updated)
-----
src/scheduler/scheduler.cpp 33e4d7cd0dfb3c4d4ef928707104034eff634ff1
Diff: https://reviews.apache.org/r/38779/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 38779: Use new HTTP status code check in scheduler.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38779/
-----------------------------------------------------------
(Updated Oct. 8, 2015, 11:06 p.m.)
Review request for mesos, Anand Mazumdar and Ben Mahler.
Repository: mesos
Description
-------
Use new HTTP status code check in scheduler.
Diffs (updated)
-----
src/scheduler/scheduler.cpp 56801ca6ffc9f9f0e4bd12dbf535e9c5251c2712
Diff: https://reviews.apache.org/r/38779/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 38779: Use new HTTP status code check in scheduler.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38779/#review101710
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38416, 38779]
All tests passed.
- Mesos ReviewBot
On Oct. 6, 2015, 8:27 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38779/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 8:27 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use new HTTP status code check in scheduler.
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp 56801ca6ffc9f9f0e4bd12dbf535e9c5251c2712
>
> Diff: https://reviews.apache.org/r/38779/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 38779: Use new HTTP status code check in scheduler.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38779/
-----------------------------------------------------------
(Updated Oct. 6, 2015, 8:27 p.m.)
Review request for mesos, Anand Mazumdar and Ben Mahler.
Repository: mesos
Description
-------
Use new HTTP status code check in scheduler.
Diffs (updated)
-----
src/scheduler/scheduler.cpp 56801ca6ffc9f9f0e4bd12dbf535e9c5251c2712
Diff: https://reviews.apache.org/r/38779/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 38779: Use new HTTP status code check in scheduler.
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38779/#review100708
-----------------------------------------------------------
Ship it!
Ship It!
- Isabel Jimenez
On Sept. 25, 2015, 10:40 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38779/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 10:40 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use new HTTP status code check in scheduler.
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp ee146eb81a8ad72bc04c62d1e223de6aa27b351d
>
> Diff: https://reviews.apache.org/r/38779/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 38779: Use new HTTP status code check in scheduler.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38779/#review100720
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38416, 38779]
All tests passed.
- Mesos ReviewBot
On Sept. 25, 2015, 10:40 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38779/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 10:40 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use new HTTP status code check in scheduler.
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp ee146eb81a8ad72bc04c62d1e223de6aa27b351d
>
> Diff: https://reviews.apache.org/r/38779/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>