You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org> on 2021/01/04 08:11:36 UTC

[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be applied to view table

Hello Aman Sinha, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16912

to look at the new patch set (#6).

Change subject: IMPALA-10412: ConvertToCNFRule can be applied to view table
......................................................................

IMPALA-10412: ConvertToCNFRule can be applied to view table

For OR predicates that reference a view, currently the ConvertToCNFRule
does not get applied since it is considered a single table predicate
even if the predicate might reference columns from different tables
within the view. This patch enables the application of this rule for
such predicates by checking the expanded view and if it satisfies the
criterion then the rule can be applied and the predicate can be pushed
eventually to the scan.

Testing:
Added planner test in inline-view.test

Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88
---
M fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java
M testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test
2 files changed, 78 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/16912/6
-- 
To view, visit http://gerrit.cloudera.org:8080/16912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie7a9a215d6b92aec07153e643268370f34186c88
Gerrit-Change-Number: 16912
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>