You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/01/29 17:20:57 UTC

[GitHub] merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker

merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker
URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164501056
 
 

 ##########
 File path: pulsar-broker/pom.xml
 ##########
 @@ -119,6 +119,34 @@
       <scope>test</scope>
     </dependency>
 
+    <dependency>
 
 Review comment:
   I think the issue is that we're not specifying ZK in the `<dependencyManagement>` section like most other dependencies. Right now we only have the `tests` ZK artifact defined there: https://github.com/apache/incubator-pulsar/blob/master/pom.xml#L168 
   
   Once we set it in the `dependencyManagement` it will override the ZK version for all the modules in the project (and transitive dependencies)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services