[GitHub] [carbondata] QiangCai commented on a change in pull request #3981: [CARBONDATA-4031] Incorrect query result after Update/Delete and Inse…

[GitBox <gi...@apache.org>]

QiangCai commented on a change in pull request #3981:
URL: https://github.com/apache/carbondata/pull/3981#discussion_r508334402



##########
File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/merge/MergeTestCase.scala
##########
@@ -723,6 +723,15 @@ class MergeTestCase extends QueryTest with BeforeAndAfterAll {
     assert(getDeleteDeltaFileCount("target", "0") == 0)
     checkAnswer(sql("select count(*) from target"), Seq(Row(3)))
     checkAnswer(sql("select * from target order by key"), Seq(Row("c", "200"), Row("d", "3"), Row("e", "100")))
+
+    // insert overwrite a partition. make sure the merge executed before still works.
+    sql(
+      """insert overwrite table target
+        | partition (value=3)
+        | select * from target where value = 100""".stripMargin)
+    checkAnswer(sql("select * from target"), Seq(Row("c", "200"), Row("e", "3"), Row("e", "100")))

Review comment:
       ```suggestion
       checkAnswer(sql("select * from target order by key,value"), Seq(Row("c", "200"), Row("e", "100"), Row("e", "3")))
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org