You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by bn...@apache.org on 2001/08/03 02:31:43 UTC
cvs commit: apr/threadproc/win32 thread.c
bnicholes 01/08/02 17:31:43
Modified: threadproc/win32 thread.c
Log:
Added a stub for apr_thread_yield()
Revision Changes Path
1.35 +5 -0 apr/threadproc/win32/thread.c
Index: thread.c
===================================================================
RCS file: /home/cvs/apr/threadproc/win32/thread.c,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -r1.34 -r1.35
--- thread.c 2001/07/24 20:20:02 1.34
+++ thread.c 2001/08/03 00:31:43 1.35
@@ -173,6 +173,11 @@
}
}
+APR_DECLARE(void) apr_thread_yield()
+{
+ SwitchToThread();
+}
+
APR_DECLARE(apr_status_t) apr_thread_data_get(void **data, const char *key,
apr_thread_t *thread)
{
Re: cvs commit: apr/threadproc/win32 thread.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
From: "Jeff Trawick" <tr...@attglobal.net>
Sent: Friday, August 03, 2001 6:36 AM
> FYI... You should commit all closely related changes at once (e.g.,
> your various implementations of apr_thread_yield()), assuming that you
> had them ready at the same time.
With one discrepancy ... please don't commit the httpd changes with the
base apr changes. The messages don't always cross correctly. It's simpler
and safer just to commit the apr/apr-util changes from the srclib tree,
and then commit the impact changes to httpd.
> > +APR_DECLARE(void) apr_thread_yield()
>
> Shouldn't this have another "void", as in
>
> APR_DECLARE(void) apr_thread_yield(void)
>
> With no parameter list declaration it looks like K&R.
That was Roy's opinion (thanks for the fixing :)
Re: cvs commit: apr/threadproc/win32 thread.c
Posted by Jeff Trawick <tr...@attglobal.net>.
FYI... You should commit all closely related changes at once (e.g.,
your various implementations of apr_thread_yield()), assuming that you
had them ready at the same time.
See minor nit below:
bnicholes@apache.org writes:
> Index: thread.c
> ===================================================================
> RCS file: /home/cvs/apr/threadproc/win32/thread.c,v
> retrieving revision 1.34
> retrieving revision 1.35
> diff -u -r1.34 -r1.35
> --- thread.c 2001/07/24 20:20:02 1.34
> +++ thread.c 2001/08/03 00:31:43 1.35
> @@ -173,6 +173,11 @@
> }
> }
>
> +APR_DECLARE(void) apr_thread_yield()
Shouldn't this have another "void", as in
APR_DECLARE(void) apr_thread_yield(void)
With no parameter list declaration it looks like K&R.
--
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...