git commit: SQOOP-1250: Oracle connector is not disabling autoCommit on created connections

[ve...@apache.org]

Updated Branches:
  refs/heads/trunk e98075976 -> 8d3454dc6


SQOOP-1250:  Oracle connector is not disabling autoCommit on created connections

(Jarek Jarcec Cecho via Venkat Ranganathan)


Project: http://git-wip-us.apache.org/repos/asf/sqoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/sqoop/commit/8d3454dc
Tree: http://git-wip-us.apache.org/repos/asf/sqoop/tree/8d3454dc
Diff: http://git-wip-us.apache.org/repos/asf/sqoop/diff/8d3454dc

Branch: refs/heads/trunk
Commit: 8d3454dc60661162c1daa510c52fd60c483e3d16
Parents: e980759
Author: Venkat Ranganathan <ve...@hortonworks.com>
Authored: Thu Dec 5 11:07:30 2013 -0800
Committer: Venkat Ranganathan <ve...@hortonworks.com>
Committed: Thu Dec 5 11:07:30 2013 -0800

----------------------------------------------------------------------
 src/java/org/apache/sqoop/manager/OracleManager.java | 6 ++++++
 1 file changed, 6 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/sqoop/blob/8d3454dc/src/java/org/apache/sqoop/manager/OracleManager.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/sqoop/manager/OracleManager.java b/src/java/org/apache/sqoop/manager/OracleManager.java
index 8008831..77b8ba3 100644
--- a/src/java/org/apache/sqoop/manager/OracleManager.java
+++ b/src/java/org/apache/sqoop/manager/OracleManager.java
@@ -331,6 +331,12 @@ public class OracleManager
     // Setting session time zone
     setSessionTimeZone(connection);
 
+    // Rest of the Sqoop code expects that the connection will have be running
+    // without autoCommit, so we need to explicitly set it to false. This is
+    // usually done directly by SqlManager in the makeConnection method, but
+    // since we are overriding it, we have to do it ourselves.
+    connection.setAutoCommit(false);
+
     return connection;
   }