You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/13 16:50:51 UTC

[GitHub] [airflow] bmckallagat-os opened a new pull request #18209: Upgrade importlib-resources version

bmckallagat-os opened a new pull request #18209:
URL: https://github.com/apache/airflow/pull/18209


   Closes #18155
   
   Update `importlib-resources` version as the current selected version is over a year old. Fixes compatibility issues with other packages.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #18209: Upgrade importlib-resources version

Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #18209:
URL: https://github.com/apache/airflow/pull/18209#issuecomment-918851329


   This broke tests in main, see #18225.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bmckallagat-os edited a comment on pull request #18209: Upgrade importlib-resources version

Posted by GitBox <gi...@apache.org>.
bmckallagat-os edited a comment on pull request #18209:
URL: https://github.com/apache/airflow/pull/18209#issuecomment-918382944


   As a note, the following unittests failed which seem to be unrelated to this change:
   
   ```
   FAILED tests/www/test_security.py::TestSecurity::test_verify_public_role_has_no_permissions - AssertionError: assert [can read on DAG:test_example_bash_operator] == []
   FAILED tests/www/views/test_views_base.py::test_resetmypasswordview_edit[pk-admin] - AttributeError: 'NoneType' object has no attribute 'password'
   ```
   
   I didn't want to patch them due to it being out of scope of this change, but just thought I would point it out. Everything else passed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bmckallagat-os commented on pull request #18209: Upgrade importlib-resources version

Posted by GitBox <gi...@apache.org>.
bmckallagat-os commented on pull request #18209:
URL: https://github.com/apache/airflow/pull/18209#issuecomment-918382944


   As a note, the following unittests failed which seem to be unrelated to this change:
   
   ```
   FAILED tests/www/test_security.py::TestSecurity::test_verify_public_role_has_no_permissions - AssertionError: assert [can read on DAG:test_example_bash_operator] == []
   FAILED tests/www/views/test_views_base.py::test_resetmypasswordview_edit[pk-admin] - AttributeError: 'NoneType' object has no attribute 'password'
   ```
   
   I didn't want to patch them due to it being out of scope of this change, but just thought I would point it out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18209: Upgrade importlib-resources version

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18209:
URL: https://github.com/apache/airflow/pull/18209#issuecomment-918381889


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโ€™s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better ๐Ÿš€.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bmckallagat-os commented on pull request #18209: Upgrade importlib-resources version

Posted by GitBox <gi...@apache.org>.
bmckallagat-os commented on pull request #18209:
URL: https://github.com/apache/airflow/pull/18209#issuecomment-918386793


   Not sure who to ping, but you commented on the ticket so @potiuk! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #18209: Upgrade importlib-resources version

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18209:
URL: https://github.com/apache/airflow/pull/18209#issuecomment-918454067


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bmckallagat-os commented on pull request #18209: Upgrade importlib-resources version

Posted by GitBox <gi...@apache.org>.
bmckallagat-os commented on pull request #18209:
URL: https://github.com/apache/airflow/pull/18209#issuecomment-918441886


   Checking the errors and will update accordingly. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18209: Upgrade importlib-resources version

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18209:
URL: https://github.com/apache/airflow/pull/18209#issuecomment-918454419


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil merged pull request #18209: Upgrade importlib-resources version

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #18209:
URL: https://github.com/apache/airflow/pull/18209


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org