[GitHub] [cassandra] dcapwell commented on a change in pull request #1440: CASSANDRA-17353 trunk: Flatten guardrails config

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #1440:
URL: https://github.com/apache/cassandra/pull/1440#discussion_r800936383



##########
File path: src/java/org/apache/cassandra/config/Config.java
##########
@@ -725,6 +723,25 @@ public static void setClientMode(boolean clientMode)
     public volatile SubnetGroups client_error_reporting_exclusions = new SubnetGroups();
     public volatile SubnetGroups internode_error_reporting_exclusions = new SubnetGroups();
 
+    public static final int DISABLED_GUARDRAIL = -1;
+    public volatile boolean guardrails_enabled = false;
+    public volatile int keyspaces_warn_threshold = DISABLED_GUARDRAIL;
+    public volatile int keyspaces_abort_threshold = DISABLED_GUARDRAIL;
+    public volatile int tables_warn_threshold = DISABLED_GUARDRAIL;
+    public volatile int tables_abort_threshold = DISABLED_GUARDRAIL;

Review comment:
       now that this is top level wondering if we should rename these 2 to be more clear; the rest I think are clear enough...
   
   100% cool leaving out of this JIRA, just something to think of before may.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org