You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by be...@apache.org on 2023/08/09 22:37:11 UTC

[superset] branch add_motherduck updated: Fix tests and lint

This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch add_motherduck
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/add_motherduck by this push:
     new de7d06901e Fix tests and lint
de7d06901e is described below

commit de7d06901ed78cf462a6a433d1d30e72306bdc63
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Wed Aug 9 15:36:44 2023 -0700

    Fix tests and lint
---
 superset-frontend/src/features/databases/DatabaseModal/index.tsx | 1 +
 tests/integration_tests/databases/api_tests.py                   | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/superset-frontend/src/features/databases/DatabaseModal/index.tsx b/superset-frontend/src/features/databases/DatabaseModal/index.tsx
index 0823b21e01..68dcfd4fed 100644
--- a/superset-frontend/src/features/databases/DatabaseModal/index.tsx
+++ b/superset-frontend/src/features/databases/DatabaseModal/index.tsx
@@ -202,6 +202,7 @@ export type DBReducerActionType =
         configuration_method: CONFIGURATION_METHOD;
         engine_information?: {};
         driver?: string;
+        sqlalchemy_uri_placeholder?: string;
       };
     }
   | {
diff --git a/tests/integration_tests/databases/api_tests.py b/tests/integration_tests/databases/api_tests.py
index 71cd6f1565..4709a11377 100644
--- a/tests/integration_tests/databases/api_tests.py
+++ b/tests/integration_tests/databases/api_tests.py
@@ -3249,7 +3249,7 @@ class TestDatabaseApi(SupersetTestCase):
                     "engine": "mysql",
                     "name": "MySQL",
                     "preferred": True,
-                    "sqlalchemy_uri_placeholder": "engine+driver://user:password@host:port/dbname[?key=value&key=value...]",
+                    "sqlalchemy_uri_placeholder": "mysql://user:password@host:port/dbname[?key=value&key=value...]",
                     "engine_information": {
                         "supports_file_upload": True,
                         "disable_ssh_tunneling": False,