You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by arunma <gi...@git.apache.org> on 2018/03/21 21:21:16 UTC

[GitHub] nifi pull request #2094: NIFI-4198 *ElasticsearchHttp processors do not expo...

Github user arunma commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2094#discussion_r176242220
  
    --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/AbstractElasticsearchHttpProcessor.java ---
    @@ -97,6 +116,27 @@
     
         private final AtomicReference<OkHttpClient> okHttpClientAtomicReference = new AtomicReference<>();
     
    +    private static final List<PropertyDescriptor> propertyDescriptors;
    +
    +    static {
    +        final List<PropertyDescriptor> properties = new ArrayList<>();
    +        properties.add(ES_URL);
    --- End diff --
    
    Thanks @mattyb149 - I was not sure about what stand to make too.  I added them in the Abstract as a matter of convenience and to avoid duplication . Please let me know if you have any strong reservations, in which case, I'll go ahead and add it to all the inherited processors. 


---