You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/07/14 00:15:04 UTC
Review Request 36456: Upgrade isort version,
which is less verbose by default.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36456/
-----------------------------------------------------------
Review request for Aurora and Brian Wickman.
Bugs: AURORA-1397
https://issues.apache.org/jira/browse/AURORA-1397
Repository: aurora
Description
-------
Additional changes here applied to appease the updated checker.
I've also added the `-df` option, to give useful output about the change that would appease the checker:
```
-df, --diff Prints a diff of all the changes isort would make to a
file, instead of changing it in place
```
Diffs
-----
build-support/python/isort 44f9659948703c75372cd70643d5631acb116c2e
build-support/python/isort-check 646cbf0bae4ccf8eac044817138ed1a7a59b261b
src/main/python/apache/aurora/admin/admin.py d2f7bd13ef335bdca7dc02177c031ac36574658d
src/main/python/apache/aurora/admin/host_maintenance.py c31e2a6fb0348c5e7074e46d61c2d2723afaf14d
src/main/python/apache/aurora/admin/maintenance.py 27d63f2340b9ee7e66e0f9ba8ce17de529be923b
src/main/python/apache/aurora/client/api/scheduler_client.py 2b8047c70d2d5bbe6d607437e2f4c9ba161e0cab
src/main/python/apache/aurora/client/base.py df53b9036e609726bc2d2e17fe2e66a2e1c7f001
src/main/python/apache/aurora/client/cli/context.py c850223588df9d9be4a644aa51adc6419a751af0
src/main/python/apache/aurora/client/cli/jobs.py 5f608419e1235f14836865b46be05d13963deb37
src/main/python/apache/aurora/client/cli/sla.py 0274988d31dbe1386e8a62a005a1408a42043e45
src/main/python/apache/aurora/client/cli/task.py b541d03d6e34dce7f4f1e38e2d970c71c8d94e08
src/main/python/apache/aurora/client/cli/update.py 70f6c69aa9226981c66c0f986fd53840c56d210f
src/main/python/apache/aurora/config/__init__.py d63177cd58126eafad20bc8edd25e57bc6d4f54a
src/main/python/apache/aurora/executor/aurora_executor.py 7ad179e632a164df98109ca7cc3098751533e70d
src/main/python/apache/thermos/config/schema_helpers.py d88792a67928e23297db918cc62b9c7ee5497432
src/test/python/apache/aurora/admin/test_admin.py 4e34ef14a0d2e536a62163377e36d52696de55a2
src/test/python/apache/aurora/client/api/test_quota_check.py ddd94667718f89e0a1f01f7798d73acd4a060909
src/test/python/apache/aurora/client/api/test_sla.py 22b9f995eaa1deae9f5c5467e0939670c099f438
src/test/python/apache/aurora/client/cli/test_context.py 1a134a2ee7d88d2d12a2bcbc122ed0f447ba997f
src/test/python/apache/aurora/client/cli/test_create.py 101a01dac27a62546822e7a4058bf6c143dcba09
src/test/python/apache/aurora/client/cli/test_kill.py 5eae70a3e830b01bfeab523c4dfc840447eb8f80
src/test/python/apache/aurora/client/cli/test_restart.py dc67cfeeeada1b226cf0fe237fde33ee0712a8cb
src/test/python/apache/aurora/client/cli/test_supdate.py c6b6ccc8570bac9c742e6458a9d09e24aa0a3bcc
src/test/python/apache/aurora/client/cli/test_update.py 22b2ca71254a1d2254cc56095f19b07531212c10
src/test/python/apache/aurora/client/cli/util.py d7d88731dd4d861c0dc69758c3276084f204d1f0
src/test/python/apache/aurora/client/hooks/test_hooked_api.py f92e715ad2eb328170c998989644aba1437ca3cb
src/test/python/apache/aurora/client/test_config.py 14a74357fc3bc3dceb83773cf4dd6013ec558218
src/test/python/apache/aurora/common/test_pex_version.py 3e6e2844231237f850e4e45cb66eb0cbdbb79029
src/test/python/apache/aurora/common/test_transport.py f307e8dcc90a0d93ec90a90f15844bc5ce0b2c09
src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py ec5b3f96b3decfd66c37301e9c2101562bd7f8d3
src/test/python/apache/aurora/executor/common/fixtures.py ebcbefa14b69ca43d1f4408d8b79970a3100fecf
src/test/python/apache/aurora/executor/common/test_announcer.py f614f2c47893e0e16877c1449cf90ca4237382a0
src/test/python/apache/aurora/executor/common/test_task_info.py 29da828c989ae065f1ed96fce2f0eb2e829fe884
src/test/python/apache/aurora/executor/test_thermos_executor.py 26b26f452fb7c718e4f99f470211dfe926ebe354
src/test/python/apache/aurora/executor/test_thermos_task_runner.py 3909aa26596a1bde287a28fde9a7e9b6f3c9c92e
src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py e485b81dddd96729bebb42ccf6d9d58dbf63a872
src/test/python/apache/thermos/config/test_schema.py 7e1867485593a8fadacb525c57264778831b24f6
Diff: https://reviews.apache.org/r/36456/diff/
Testing
-------
```
$ ./build-support/python/isort-check; echo $?
0
```
(note that there is no output about files passing checks)
Thanks,
Bill Farner
Re: Review Request 36456: Upgrade isort version,
which is less verbose by default.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36456/#review91644
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Wickman
On July 13, 2015, 10:15 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36456/
> -----------------------------------------------------------
>
> (Updated July 13, 2015, 10:15 p.m.)
>
>
> Review request for Aurora and Brian Wickman.
>
>
> Bugs: AURORA-1397
> https://issues.apache.org/jira/browse/AURORA-1397
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Additional changes here applied to appease the updated checker.
>
> I've also added the `-df` option, to give useful output about the change that would appease the checker:
> ```
> -df, --diff Prints a diff of all the changes isort would make to a
> file, instead of changing it in place
> ```
>
>
> Diffs
> -----
>
> build-support/python/isort 44f9659948703c75372cd70643d5631acb116c2e
> build-support/python/isort-check 646cbf0bae4ccf8eac044817138ed1a7a59b261b
> src/main/python/apache/aurora/admin/admin.py d2f7bd13ef335bdca7dc02177c031ac36574658d
> src/main/python/apache/aurora/admin/host_maintenance.py c31e2a6fb0348c5e7074e46d61c2d2723afaf14d
> src/main/python/apache/aurora/admin/maintenance.py 27d63f2340b9ee7e66e0f9ba8ce17de529be923b
> src/main/python/apache/aurora/client/api/scheduler_client.py 2b8047c70d2d5bbe6d607437e2f4c9ba161e0cab
> src/main/python/apache/aurora/client/base.py df53b9036e609726bc2d2e17fe2e66a2e1c7f001
> src/main/python/apache/aurora/client/cli/context.py c850223588df9d9be4a644aa51adc6419a751af0
> src/main/python/apache/aurora/client/cli/jobs.py 5f608419e1235f14836865b46be05d13963deb37
> src/main/python/apache/aurora/client/cli/sla.py 0274988d31dbe1386e8a62a005a1408a42043e45
> src/main/python/apache/aurora/client/cli/task.py b541d03d6e34dce7f4f1e38e2d970c71c8d94e08
> src/main/python/apache/aurora/client/cli/update.py 70f6c69aa9226981c66c0f986fd53840c56d210f
> src/main/python/apache/aurora/config/__init__.py d63177cd58126eafad20bc8edd25e57bc6d4f54a
> src/main/python/apache/aurora/executor/aurora_executor.py 7ad179e632a164df98109ca7cc3098751533e70d
> src/main/python/apache/thermos/config/schema_helpers.py d88792a67928e23297db918cc62b9c7ee5497432
> src/test/python/apache/aurora/admin/test_admin.py 4e34ef14a0d2e536a62163377e36d52696de55a2
> src/test/python/apache/aurora/client/api/test_quota_check.py ddd94667718f89e0a1f01f7798d73acd4a060909
> src/test/python/apache/aurora/client/api/test_sla.py 22b9f995eaa1deae9f5c5467e0939670c099f438
> src/test/python/apache/aurora/client/cli/test_context.py 1a134a2ee7d88d2d12a2bcbc122ed0f447ba997f
> src/test/python/apache/aurora/client/cli/test_create.py 101a01dac27a62546822e7a4058bf6c143dcba09
> src/test/python/apache/aurora/client/cli/test_kill.py 5eae70a3e830b01bfeab523c4dfc840447eb8f80
> src/test/python/apache/aurora/client/cli/test_restart.py dc67cfeeeada1b226cf0fe237fde33ee0712a8cb
> src/test/python/apache/aurora/client/cli/test_supdate.py c6b6ccc8570bac9c742e6458a9d09e24aa0a3bcc
> src/test/python/apache/aurora/client/cli/test_update.py 22b2ca71254a1d2254cc56095f19b07531212c10
> src/test/python/apache/aurora/client/cli/util.py d7d88731dd4d861c0dc69758c3276084f204d1f0
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py f92e715ad2eb328170c998989644aba1437ca3cb
> src/test/python/apache/aurora/client/test_config.py 14a74357fc3bc3dceb83773cf4dd6013ec558218
> src/test/python/apache/aurora/common/test_pex_version.py 3e6e2844231237f850e4e45cb66eb0cbdbb79029
> src/test/python/apache/aurora/common/test_transport.py f307e8dcc90a0d93ec90a90f15844bc5ce0b2c09
> src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py ec5b3f96b3decfd66c37301e9c2101562bd7f8d3
> src/test/python/apache/aurora/executor/common/fixtures.py ebcbefa14b69ca43d1f4408d8b79970a3100fecf
> src/test/python/apache/aurora/executor/common/test_announcer.py f614f2c47893e0e16877c1449cf90ca4237382a0
> src/test/python/apache/aurora/executor/common/test_task_info.py 29da828c989ae065f1ed96fce2f0eb2e829fe884
> src/test/python/apache/aurora/executor/test_thermos_executor.py 26b26f452fb7c718e4f99f470211dfe926ebe354
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 3909aa26596a1bde287a28fde9a7e9b6f3c9c92e
> src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py e485b81dddd96729bebb42ccf6d9d58dbf63a872
> src/test/python/apache/thermos/config/test_schema.py 7e1867485593a8fadacb525c57264778831b24f6
>
> Diff: https://reviews.apache.org/r/36456/diff/
>
>
> Testing
> -------
>
> ```
> $ ./build-support/python/isort-check; echo $?
> 0
> ```
>
> (note that there is no output about files passing checks)
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 36456: Upgrade isort version,
which is less verbose by default.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36456/#review91549
-----------------------------------------------------------
Ship it!
Master (190daed) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On July 13, 2015, 10:15 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36456/
> -----------------------------------------------------------
>
> (Updated July 13, 2015, 10:15 p.m.)
>
>
> Review request for Aurora and Brian Wickman.
>
>
> Bugs: AURORA-1397
> https://issues.apache.org/jira/browse/AURORA-1397
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Additional changes here applied to appease the updated checker.
>
> I've also added the `-df` option, to give useful output about the change that would appease the checker:
> ```
> -df, --diff Prints a diff of all the changes isort would make to a
> file, instead of changing it in place
> ```
>
>
> Diffs
> -----
>
> build-support/python/isort 44f9659948703c75372cd70643d5631acb116c2e
> build-support/python/isort-check 646cbf0bae4ccf8eac044817138ed1a7a59b261b
> src/main/python/apache/aurora/admin/admin.py d2f7bd13ef335bdca7dc02177c031ac36574658d
> src/main/python/apache/aurora/admin/host_maintenance.py c31e2a6fb0348c5e7074e46d61c2d2723afaf14d
> src/main/python/apache/aurora/admin/maintenance.py 27d63f2340b9ee7e66e0f9ba8ce17de529be923b
> src/main/python/apache/aurora/client/api/scheduler_client.py 2b8047c70d2d5bbe6d607437e2f4c9ba161e0cab
> src/main/python/apache/aurora/client/base.py df53b9036e609726bc2d2e17fe2e66a2e1c7f001
> src/main/python/apache/aurora/client/cli/context.py c850223588df9d9be4a644aa51adc6419a751af0
> src/main/python/apache/aurora/client/cli/jobs.py 5f608419e1235f14836865b46be05d13963deb37
> src/main/python/apache/aurora/client/cli/sla.py 0274988d31dbe1386e8a62a005a1408a42043e45
> src/main/python/apache/aurora/client/cli/task.py b541d03d6e34dce7f4f1e38e2d970c71c8d94e08
> src/main/python/apache/aurora/client/cli/update.py 70f6c69aa9226981c66c0f986fd53840c56d210f
> src/main/python/apache/aurora/config/__init__.py d63177cd58126eafad20bc8edd25e57bc6d4f54a
> src/main/python/apache/aurora/executor/aurora_executor.py 7ad179e632a164df98109ca7cc3098751533e70d
> src/main/python/apache/thermos/config/schema_helpers.py d88792a67928e23297db918cc62b9c7ee5497432
> src/test/python/apache/aurora/admin/test_admin.py 4e34ef14a0d2e536a62163377e36d52696de55a2
> src/test/python/apache/aurora/client/api/test_quota_check.py ddd94667718f89e0a1f01f7798d73acd4a060909
> src/test/python/apache/aurora/client/api/test_sla.py 22b9f995eaa1deae9f5c5467e0939670c099f438
> src/test/python/apache/aurora/client/cli/test_context.py 1a134a2ee7d88d2d12a2bcbc122ed0f447ba997f
> src/test/python/apache/aurora/client/cli/test_create.py 101a01dac27a62546822e7a4058bf6c143dcba09
> src/test/python/apache/aurora/client/cli/test_kill.py 5eae70a3e830b01bfeab523c4dfc840447eb8f80
> src/test/python/apache/aurora/client/cli/test_restart.py dc67cfeeeada1b226cf0fe237fde33ee0712a8cb
> src/test/python/apache/aurora/client/cli/test_supdate.py c6b6ccc8570bac9c742e6458a9d09e24aa0a3bcc
> src/test/python/apache/aurora/client/cli/test_update.py 22b2ca71254a1d2254cc56095f19b07531212c10
> src/test/python/apache/aurora/client/cli/util.py d7d88731dd4d861c0dc69758c3276084f204d1f0
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py f92e715ad2eb328170c998989644aba1437ca3cb
> src/test/python/apache/aurora/client/test_config.py 14a74357fc3bc3dceb83773cf4dd6013ec558218
> src/test/python/apache/aurora/common/test_pex_version.py 3e6e2844231237f850e4e45cb66eb0cbdbb79029
> src/test/python/apache/aurora/common/test_transport.py f307e8dcc90a0d93ec90a90f15844bc5ce0b2c09
> src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py ec5b3f96b3decfd66c37301e9c2101562bd7f8d3
> src/test/python/apache/aurora/executor/common/fixtures.py ebcbefa14b69ca43d1f4408d8b79970a3100fecf
> src/test/python/apache/aurora/executor/common/test_announcer.py f614f2c47893e0e16877c1449cf90ca4237382a0
> src/test/python/apache/aurora/executor/common/test_task_info.py 29da828c989ae065f1ed96fce2f0eb2e829fe884
> src/test/python/apache/aurora/executor/test_thermos_executor.py 26b26f452fb7c718e4f99f470211dfe926ebe354
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 3909aa26596a1bde287a28fde9a7e9b6f3c9c92e
> src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py e485b81dddd96729bebb42ccf6d9d58dbf63a872
> src/test/python/apache/thermos/config/test_schema.py 7e1867485593a8fadacb525c57264778831b24f6
>
> Diff: https://reviews.apache.org/r/36456/diff/
>
>
> Testing
> -------
>
> ```
> $ ./build-support/python/isort-check; echo $?
> 0
> ```
>
> (note that there is no output about files passing checks)
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 36456: Upgrade isort version,
which is less verbose by default.
Posted by Brian Brazil <br...@boxever.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36456/#review91545
-----------------------------------------------------------
Ship it!
- Brian Brazil
On July 13, 2015, 10:15 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36456/
> -----------------------------------------------------------
>
> (Updated July 13, 2015, 10:15 p.m.)
>
>
> Review request for Aurora and Brian Wickman.
>
>
> Bugs: AURORA-1397
> https://issues.apache.org/jira/browse/AURORA-1397
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Additional changes here applied to appease the updated checker.
>
> I've also added the `-df` option, to give useful output about the change that would appease the checker:
> ```
> -df, --diff Prints a diff of all the changes isort would make to a
> file, instead of changing it in place
> ```
>
>
> Diffs
> -----
>
> build-support/python/isort 44f9659948703c75372cd70643d5631acb116c2e
> build-support/python/isort-check 646cbf0bae4ccf8eac044817138ed1a7a59b261b
> src/main/python/apache/aurora/admin/admin.py d2f7bd13ef335bdca7dc02177c031ac36574658d
> src/main/python/apache/aurora/admin/host_maintenance.py c31e2a6fb0348c5e7074e46d61c2d2723afaf14d
> src/main/python/apache/aurora/admin/maintenance.py 27d63f2340b9ee7e66e0f9ba8ce17de529be923b
> src/main/python/apache/aurora/client/api/scheduler_client.py 2b8047c70d2d5bbe6d607437e2f4c9ba161e0cab
> src/main/python/apache/aurora/client/base.py df53b9036e609726bc2d2e17fe2e66a2e1c7f001
> src/main/python/apache/aurora/client/cli/context.py c850223588df9d9be4a644aa51adc6419a751af0
> src/main/python/apache/aurora/client/cli/jobs.py 5f608419e1235f14836865b46be05d13963deb37
> src/main/python/apache/aurora/client/cli/sla.py 0274988d31dbe1386e8a62a005a1408a42043e45
> src/main/python/apache/aurora/client/cli/task.py b541d03d6e34dce7f4f1e38e2d970c71c8d94e08
> src/main/python/apache/aurora/client/cli/update.py 70f6c69aa9226981c66c0f986fd53840c56d210f
> src/main/python/apache/aurora/config/__init__.py d63177cd58126eafad20bc8edd25e57bc6d4f54a
> src/main/python/apache/aurora/executor/aurora_executor.py 7ad179e632a164df98109ca7cc3098751533e70d
> src/main/python/apache/thermos/config/schema_helpers.py d88792a67928e23297db918cc62b9c7ee5497432
> src/test/python/apache/aurora/admin/test_admin.py 4e34ef14a0d2e536a62163377e36d52696de55a2
> src/test/python/apache/aurora/client/api/test_quota_check.py ddd94667718f89e0a1f01f7798d73acd4a060909
> src/test/python/apache/aurora/client/api/test_sla.py 22b9f995eaa1deae9f5c5467e0939670c099f438
> src/test/python/apache/aurora/client/cli/test_context.py 1a134a2ee7d88d2d12a2bcbc122ed0f447ba997f
> src/test/python/apache/aurora/client/cli/test_create.py 101a01dac27a62546822e7a4058bf6c143dcba09
> src/test/python/apache/aurora/client/cli/test_kill.py 5eae70a3e830b01bfeab523c4dfc840447eb8f80
> src/test/python/apache/aurora/client/cli/test_restart.py dc67cfeeeada1b226cf0fe237fde33ee0712a8cb
> src/test/python/apache/aurora/client/cli/test_supdate.py c6b6ccc8570bac9c742e6458a9d09e24aa0a3bcc
> src/test/python/apache/aurora/client/cli/test_update.py 22b2ca71254a1d2254cc56095f19b07531212c10
> src/test/python/apache/aurora/client/cli/util.py d7d88731dd4d861c0dc69758c3276084f204d1f0
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py f92e715ad2eb328170c998989644aba1437ca3cb
> src/test/python/apache/aurora/client/test_config.py 14a74357fc3bc3dceb83773cf4dd6013ec558218
> src/test/python/apache/aurora/common/test_pex_version.py 3e6e2844231237f850e4e45cb66eb0cbdbb79029
> src/test/python/apache/aurora/common/test_transport.py f307e8dcc90a0d93ec90a90f15844bc5ce0b2c09
> src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py ec5b3f96b3decfd66c37301e9c2101562bd7f8d3
> src/test/python/apache/aurora/executor/common/fixtures.py ebcbefa14b69ca43d1f4408d8b79970a3100fecf
> src/test/python/apache/aurora/executor/common/test_announcer.py f614f2c47893e0e16877c1449cf90ca4237382a0
> src/test/python/apache/aurora/executor/common/test_task_info.py 29da828c989ae065f1ed96fce2f0eb2e829fe884
> src/test/python/apache/aurora/executor/test_thermos_executor.py 26b26f452fb7c718e4f99f470211dfe926ebe354
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 3909aa26596a1bde287a28fde9a7e9b6f3c9c92e
> src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py e485b81dddd96729bebb42ccf6d9d58dbf63a872
> src/test/python/apache/thermos/config/test_schema.py 7e1867485593a8fadacb525c57264778831b24f6
>
> Diff: https://reviews.apache.org/r/36456/diff/
>
>
> Testing
> -------
>
> ```
> $ ./build-support/python/isort-check; echo $?
> 0
> ```
>
> (note that there is no output about files passing checks)
>
>
> Thanks,
>
> Bill Farner
>
>