[jira] [Commented] (FLINK-3292) Bug in flink-jdbc. Not all JDBC drivers supported

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117913#comment-15117913 ] 

ASF GitHub Bot commented on FLINK-3292:
---------------------------------------

GitHub user sbcd90 opened a pull request:

    https://github.com/apache/flink/pull/1551

    [FLINK-3292]Fix for Bug in flink-jdbc. Not all JDBC drivers supported

    Hello,
    
    Here is the fix for issue FLINK-3292. Kindly review & merge.
    
    Thanks & regards,
    Subhobrata

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sbcd90/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1551.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1551
    
----
commit 8f1ab49c823d53d4b46eb57789bdca29533bb37e
Author: Subhobrata Dey <sb...@gmail.com>
Date:   2016-01-26T20:18:49Z

    [FLINK-3292]Fix for Bug in flink-jdbc. Not all JDBC drivers supported

----


> Bug in flink-jdbc. Not all JDBC drivers supported
> -------------------------------------------------
>
>                 Key: FLINK-3292
>                 URL: https://issues.apache.org/jira/browse/FLINK-3292
>             Project: Flink
>          Issue Type: Bug
>          Components: other
>    Affects Versions: 1.0.0
>            Reporter: Subhobrata Dey
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> Hello,
> In method open in JDBCInputFormat.java, while using dbConn.createStatement, the resultSetType & resultSetConcurrency are hardcoded. 
> These two fields may vary with different JDBC drivers & hence it fails in a few cases like SAP HANA Jdbc driver. 
> There are two variants of the method dbCon.createStatement, one with parameters & the other without  parameters. Both should be supported. 
> Thanks & regards,
> Subhobrata



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)