[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #89: Core allocation/reservation logic renovation

[GitBox <gi...@apache.org>]

wilfred-s commented on a change in pull request #89: Core allocation/reservation logic renovation
URL: https://github.com/apache/incubator-yunikorn-core/pull/89#discussion_r381608974
 
 

 ##########
 File path: pkg/cache/initializer.go
 ##########
 @@ -194,21 +194,16 @@ func checkResourceConfigurationsForQueue(cur *QueueInfo, parent *QueueInfo) erro
 		cur.GuaranteedResource = resources.NewResource()
 	}
 
-	// If Max resource not set, use parent's max resource
-	if cur.MaxResource == nil && parent != nil && parent.MaxResource != nil {
-		cur.MaxResource = parent.MaxResource
-	}
-
 
 Review comment:
   yes, max resources is calculated recursively automatically in the new logic
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org