You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Igor Drobiazko (JIRA)" <ji...@apache.org> on 2010/08/05 17:37:16 UTC

[jira] Created: (TAP5-1234) Store the name of the active page into RequestGlobals inside PageRenderRequestFilter and ComponentEventRequestHandler

Store the name of the active page into RequestGlobals inside PageRenderRequestFilter and ComponentEventRequestHandler
---------------------------------------------------------------------------------------------------------------------

                 Key: TAP5-1234
                 URL: https://issues.apache.org/jira/browse/TAP5-1234
             Project: Tapestry 5
          Issue Type: Improvement
          Components: tapestry-core
    Affects Versions: 5.2.0
            Reporter: Igor Drobiazko


Currently the name of the active page is stored into RequestGlobals inside a ComponentRequestFilter (InitializeActivePageName). This is fine for most cases. 

If you terminate the Dispatcher chain before ComponentEventDispatcher and send a response using PageRenderRequestHandler service , then ComponentRequestHandler pipeline is never called. In this case the name of theactive page is never stored into requestGlobals. This can result in weird exceptions if the target page contains a Form. During beginRender phase Form tries to access the active page from ComponentSource service, which throws an exception if the activae page is not set inside RequestGlobals.

Execption message: The identity of the active page for this request has not yet been established.

Storing the activa page name into RequestGlobals should be moved from ComponentRequestFilter  into PageRenderRequestFilter  and ComponentEventRequestHandler.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (TAP5-1234) Store the name of the active page into RequestGlobals inside PageRenderRequestFilter and ComponentEventRequestHandler

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1234.
--------------------------------------

    Resolution: Duplicate

I think the TAP5-1201 fix will cover these situations as well.

> Store the name of the active page into RequestGlobals inside PageRenderRequestFilter and ComponentEventRequestHandler
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1234
>                 URL: https://issues.apache.org/jira/browse/TAP5-1234
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.2.0
>            Reporter: Igor Drobiazko
>
> Currently the name of the active page is stored into RequestGlobals inside a ComponentRequestFilter (InitializeActivePageName). This is fine for most cases. 
> If you terminate the Dispatcher chain before ComponentEventDispatcher and send a response using PageRenderRequestHandler service , then ComponentRequestHandler pipeline is never called. In this case the name of theactive page is never stored into requestGlobals. This can result in weird exceptions if the target page contains a Form. During beginRender phase Form tries to access the active page from ComponentSource service, which throws an exception if the activae page is not set inside RequestGlobals.
> Execption message: The identity of the active page for this request has not yet been established.
> Storing the activa page name into RequestGlobals should be moved from ComponentRequestFilter  into PageRenderRequestFilter  and ComponentEventRequestHandler.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (TAP5-1234) Store the name of the active page into RequestGlobals inside PageRenderRequestFilter and ComponentEventRequestHandler

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1234.
--------------------------------------

    Resolution: Duplicate

I think the TAP5-1201 fix will cover these situations as well.

> Store the name of the active page into RequestGlobals inside PageRenderRequestFilter and ComponentEventRequestHandler
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1234
>                 URL: https://issues.apache.org/jira/browse/TAP5-1234
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.2.0
>            Reporter: Igor Drobiazko
>
> Currently the name of the active page is stored into RequestGlobals inside a ComponentRequestFilter (InitializeActivePageName). This is fine for most cases. 
> If you terminate the Dispatcher chain before ComponentEventDispatcher and send a response using PageRenderRequestHandler service , then ComponentRequestHandler pipeline is never called. In this case the name of theactive page is never stored into requestGlobals. This can result in weird exceptions if the target page contains a Form. During beginRender phase Form tries to access the active page from ComponentSource service, which throws an exception if the activae page is not set inside RequestGlobals.
> Execption message: The identity of the active page for this request has not yet been established.
> Storing the activa page name into RequestGlobals should be moved from ComponentRequestFilter  into PageRenderRequestFilter  and ComponentEventRequestHandler.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.