[GitHub] [hadoop] mkuchenbecker commented on a diff in pull request #5691: HDFS-17026. Configuring NamenodeHeartbeatService to update JMX on low…

["mkuchenbecker (via GitHub)" <gi...@apache.org>]

mkuchenbecker commented on code in PR #5691:
URL: https://github.com/apache/hadoop/pull/5691#discussion_r1207150754


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java:
##########
@@ -107,6 +110,15 @@ public class NamenodeHeartbeatService extends PeriodicService {
   /** URL scheme to use for JMX calls. */
   private String scheme;
 
+  /** Frequency of updates to JMX report. */
+  private long updateJmxIntervalMs;
+  /** Timestamp of last attempt to update JMX report. */
+  private long lastJmxUpdateAttempt;

Review Comment:
   Should we be getting a glob of FSNamesystem metrics as compared to querying the specific metrics needed?
   
   I.e. this queries `FSNamesystem*`, and not all those metrics are eneded or used. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org