[GitHub] [skywalking] zifeihan edited a comment on pull request #6642: make sync metrics concurrency

[GitBox <gi...@apache.org>]

zifeihan edited a comment on pull request #6642:
URL: https://github.com/apache/skywalking/pull/6642#issuecomment-809854581


   > I know it is helpful, that is why I raised the issue. The key here is what is a good default way. And whether we need multi threads in prepare stage. From @EvanLjp provided data, we don't. @zifeihan Do you have some recommends about this? And any data to prove?
   
   According to my data, We have more than 10+ billion segment and more than 80+ billion metrics data on Saturday(Affected by business), before the modification, at the peak, the preparation time was close to one minute, and some reached several minutes. After the modification, most of the time is less than 10 seconds.  perpare's thread pool and batch save are one, and the number of threads is Runtime.getRuntime().availableProcessors()


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org