[GitHub] [spark] MaxGekk commented on a change in pull request #31229: [SPARK-34149][SQL] Refresh cache in v2 `ALTER TABLE .. ADD PARTITION`

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #31229:
URL: https://github.com/apache/spark/pull/31229#discussion_r559377476



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterTableAddPartitionExec.scala
##########
@@ -44,22 +45,25 @@ case class AlterTableAddPartitionExec(
         table.name(), existsParts.map(_.ident), table.partitionSchema())
     }
 
-    notExistsParts match {
-      case Seq() => // Nothing will be done
+    val isTableAltered = notExistsParts match {
+      case Seq() => false // Nothing will be done
       case Seq(partitionSpec) =>
         val partProp = partitionSpec.location.map(loc => "location" -> loc).toMap
         table.createPartition(partitionSpec.ident, partProp.asJava)
+        true

Review comment:
       The v2 API looks inconsistent to me. I do believe either both `dropPartition` and `createPartition` should return nothing (and indicate errors via exceptions) or both methods should return `boolean`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org