You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2014/07/22 10:39:48 UTC

Re: Review Request 22805: CLOUDSTACK-1466:Adding automation tests for Secondary Storage Limits

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22805/
-----------------------------------------------------------

(Updated July 22, 2014, 8:39 a.m.)


Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-1466
    https://issues.apache.org/jira/browse/CLOUDSTACK-1466


Repository: cloudstack-git


Description
-------

Automation tests for Secondary Storage Limits. This patch contains 2 test suites. 2 more test suites to follow.


Diffs
-----

  test/integration/component/test_ss_domain_limits.py PRE-CREATION 
  test/integration/component/test_ss_limits.py PRE-CREATION 
  test/integration/component/test_ss_max_limits.py PRE-CREATION 
  test/integration/component/test_ss_project_limits.py PRE-CREATION 
  tools/marvin/marvin/config/test_data.py d870c98 
  tools/marvin/marvin/lib/base.py 1ea4fa7 

Diff: https://reviews.apache.org/r/22805/diff/


Testing
-------

Yes.


Thanks,

Ashutosh Kelkar


Re: Review Request 22805: CLOUDSTACK-1466:Adding automation tests for Secondary Storage Limits

Posted by sanjeev n <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22805/#review51758
-----------------------------------------------------------

Ship it!


Ship It!

- sanjeev n


On Aug. 27, 2014, 8:31 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22805/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2014, 8:31 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-1466
>     https://issues.apache.org/jira/browse/CLOUDSTACK-1466
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Automation tests for Secondary Storage Limits. This patch contains 2 test suites. 2 more test suites to follow.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_ss_domain_limits.py PRE-CREATION 
>   test/integration/component/test_ss_limits.py PRE-CREATION 
>   test/integration/component/test_ss_max_limits.py PRE-CREATION 
>   test/integration/component/test_ss_project_limits.py PRE-CREATION 
>   tools/marvin/marvin/config/test_data.py ade8657 
>   tools/marvin/marvin/lib/base.py 99a541a 
> 
> Diff: https://reviews.apache.org/r/22805/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request 22805: CLOUDSTACK-1466:Adding automation tests for Secondary Storage Limits

Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22805/
-----------------------------------------------------------

(Updated Aug. 27, 2014, 8:31 a.m.)


Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.


Changes
-------

Review Changes


Bugs: CLOUDSTACK-1466
    https://issues.apache.org/jira/browse/CLOUDSTACK-1466


Repository: cloudstack-git


Description
-------

Automation tests for Secondary Storage Limits. This patch contains 2 test suites. 2 more test suites to follow.


Diffs (updated)
-----

  test/integration/component/test_ss_domain_limits.py PRE-CREATION 
  test/integration/component/test_ss_limits.py PRE-CREATION 
  test/integration/component/test_ss_max_limits.py PRE-CREATION 
  test/integration/component/test_ss_project_limits.py PRE-CREATION 
  tools/marvin/marvin/config/test_data.py ade8657 
  tools/marvin/marvin/lib/base.py 99a541a 

Diff: https://reviews.apache.org/r/22805/diff/


Testing
-------

Yes.


Thanks,

Ashutosh Kelkar


Re: Review Request 22805: CLOUDSTACK-1466:Adding automation tests for Secondary Storage Limits

Posted by Ashutosh Kelkar <as...@clogeny.com>.

> On July 22, 2014, 12:19 p.m., sanjeev n wrote:
> > test/integration/component/test_ss_domain_limits.py, line 244
> > <https://reviews.apache.org/r/22805/diff/3/?file=616580#file616580line244>
> >
> >     Step6 is missing. Please add test for step6

Done.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22805/#review48358
-----------------------------------------------------------


On July 22, 2014, 8:39 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22805/
> -----------------------------------------------------------
> 
> (Updated July 22, 2014, 8:39 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-1466
>     https://issues.apache.org/jira/browse/CLOUDSTACK-1466
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Automation tests for Secondary Storage Limits. This patch contains 2 test suites. 2 more test suites to follow.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_ss_domain_limits.py PRE-CREATION 
>   test/integration/component/test_ss_limits.py PRE-CREATION 
>   test/integration/component/test_ss_max_limits.py PRE-CREATION 
>   test/integration/component/test_ss_project_limits.py PRE-CREATION 
>   tools/marvin/marvin/config/test_data.py d870c98 
>   tools/marvin/marvin/lib/base.py 1ea4fa7 
> 
> Diff: https://reviews.apache.org/r/22805/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request 22805: CLOUDSTACK-1466:Adding automation tests for Secondary Storage Limits

Posted by sanjeev n <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22805/#review48358
-----------------------------------------------------------



test/integration/component/test_ss_domain_limits.py
<https://reviews.apache.org/r/22805/#comment84906>

    Step6 is missing. Please add test for step6


- sanjeev n


On July 22, 2014, 8:39 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22805/
> -----------------------------------------------------------
> 
> (Updated July 22, 2014, 8:39 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-1466
>     https://issues.apache.org/jira/browse/CLOUDSTACK-1466
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Automation tests for Secondary Storage Limits. This patch contains 2 test suites. 2 more test suites to follow.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_ss_domain_limits.py PRE-CREATION 
>   test/integration/component/test_ss_limits.py PRE-CREATION 
>   test/integration/component/test_ss_max_limits.py PRE-CREATION 
>   test/integration/component/test_ss_project_limits.py PRE-CREATION 
>   tools/marvin/marvin/config/test_data.py d870c98 
>   tools/marvin/marvin/lib/base.py 1ea4fa7 
> 
> Diff: https://reviews.apache.org/r/22805/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>