You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/07/22 08:44:27 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #4776: [Transaction][Buffer]Add new marker to show which message belongs to transaction

sijie commented on a change in pull request #4776: [Transaction][Buffer]Add new marker to show which message belongs to transaction
URL: https://github.com/apache/pulsar/pull/4776#discussion_r305732623
 
 

 ##########
 File path: pulsar-common/src/main/proto/PulsarApi.proto
 ##########
 @@ -123,6 +123,11 @@ message MessageMetadata {
     // internal metadata instead of application published data.
     // Markers will generally not be propagated back to clients
     optional int32 marker_type = 20;
+
+	// transaction related message info
+	optional int64 indirect_ledger_id = 21;
 
 Review comment:
   I don't think we need this field anymore. We can remove it for now. If we really need it in future, we can add it back.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services