You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2018/08/16 23:04:00 UTC

[jira] [Updated] (PARQUET-1384) [C++] Clang compiler warnings in bloom_filter-test.cc

     [ https://issues.apache.org/jira/browse/PARQUET-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wes McKinney updated PARQUET-1384:
----------------------------------
    Description: 
{code}
[69/95] Building CXX object src/parquet/CMakeFiles/bloom_filter-test.dir/bloom_filter-test.cc.o
../src/parquet/bloom_filter-test.cc:75:36: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
  BlockSplitBloomFilter de_bloom = std::move(BlockSplitBloomFilter::Deserialize(&source));
                                   ^
../src/parquet/bloom_filter-test.cc:75:36: note: remove std::move call here
  BlockSplitBloomFilter de_bloom = std::move(BlockSplitBloomFilter::Deserialize(&source));
                                   ^~~~~~~~~~                                           ~
../src/parquet/bloom_filter-test.cc:168:7: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
      std::move(BlockSplitBloomFilter::Deserialize(&source));
      ^
../src/parquet/bloom_filter-test.cc:168:7: note: remove std::move call here
      std::move(BlockSplitBloomFilter::Deserialize(&source));
      ^~~~~~~~~~                                           ~
../src/parquet/bloom_filter-test.cc:164:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
  handle->Read(size, &buffer);
  ^~~~~~~~~~~~ ~~~~~~~~~~~~~
../src/parquet/bloom_filter-test.cc:192:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
  handle->Seek(0);
  ^~~~~~~~~~~~ ~
../src/parquet/bloom_filter-test.cc:193:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
  handle->GetSize(&size);
  ^~~~~~~~~~~~~~~ ~~~~~
../src/parquet/bloom_filter-test.cc:195:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
  handle->Read(size, &buffer2);
{code}

> [C++] Clang compiler warnings in bloom_filter-test.cc
> -----------------------------------------------------
>
>                 Key: PARQUET-1384
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1384
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-cpp
>            Reporter: Wes McKinney
>            Assignee: Junjie Chen
>            Priority: Major
>             Fix For: cpp-1.5.0
>
>
> {code}
> [69/95] Building CXX object src/parquet/CMakeFiles/bloom_filter-test.dir/bloom_filter-test.cc.o
> ../src/parquet/bloom_filter-test.cc:75:36: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
>   BlockSplitBloomFilter de_bloom = std::move(BlockSplitBloomFilter::Deserialize(&source));
>                                    ^
> ../src/parquet/bloom_filter-test.cc:75:36: note: remove std::move call here
>   BlockSplitBloomFilter de_bloom = std::move(BlockSplitBloomFilter::Deserialize(&source));
>                                    ^~~~~~~~~~                                           ~
> ../src/parquet/bloom_filter-test.cc:168:7: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
>       std::move(BlockSplitBloomFilter::Deserialize(&source));
>       ^
> ../src/parquet/bloom_filter-test.cc:168:7: note: remove std::move call here
>       std::move(BlockSplitBloomFilter::Deserialize(&source));
>       ^~~~~~~~~~                                           ~
> ../src/parquet/bloom_filter-test.cc:164:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
>   handle->Read(size, &buffer);
>   ^~~~~~~~~~~~ ~~~~~~~~~~~~~
> ../src/parquet/bloom_filter-test.cc:192:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
>   handle->Seek(0);
>   ^~~~~~~~~~~~ ~
> ../src/parquet/bloom_filter-test.cc:193:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
>   handle->GetSize(&size);
>   ^~~~~~~~~~~~~~~ ~~~~~
> ../src/parquet/bloom_filter-test.cc:195:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
>   handle->Read(size, &buffer2);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)