[jira] [Comment Edited] (YARN-6953) Clean up ResourceUtils.setMinimumAllocationForMandatoryResources() and setMaximumAllocationForMandatoryResources()

["Manikandan R (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119591#comment-16119591 ] 

Manikandan R edited comment on YARN-6953 at 8/9/17 9:00 AM:
------------------------------------------------------------

[~sunilg] Thanks for review.

Agree with your comments. Had similar thought (not exactly, but to avoid having same code) while doing changes, fluctuated back and forth for sometime :) and settled down with the patch later assuming mandatory resources count is always going to be 2.  Will clean it up.


was (Author: manirajv06@gmail.com):
[~sunilg] Thanks for review.

Agree with your comments. Had similar thought (to avoid having same code) while doing changes, fluctuated back and forth for sometime :) and settled down with the patch later assuming mandatory resources count is always going to be 2.  Will clean it up.

> Clean up ResourceUtils.setMinimumAllocationForMandatoryResources() and setMaximumAllocationForMandatoryResources()
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-6953
>                 URL: https://issues.apache.org/jira/browse/YARN-6953
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: YARN-3926
>            Reporter: Daniel Templeton
>            Assignee: Manikandan R
>            Priority: Minor
>              Labels: newbie
>         Attachments: YARN-6953-YARN-3926.001.patch, YARN-6953-YARN-3926.002.patch, YARN-6953-YARN-3926.003.patch, YARN-6953-YARN-3926.004.patch
>
>
> The {{setMinimumAllocationForMandatoryResources()}} and {{setMaximumAllocationForMandatoryResources()}} methods are quite convoluted.  They'd be much simpler if they just handled CPU and memory manually instead of trying to be clever about doing it in a loop.  There are also issues, such as the log warning always talking about memory or the last element of the inner array being a copy of the first element.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org