You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by st...@apache.org on 2005/03/29 06:15:07 UTC

svn commit: r159346 - in perl/modperl/trunk/t: filter/TestFilter/in_bbs_body.pm filter/in_bbs_body.t response/TestAPI/sub_request.pm response/TestModperl/endav.pm

Author: stas
Date: Mon Mar 28 20:15:05 2005
New Revision: 159346

URL: http://svn.apache.org/viewcvs?view=rev&rev=159346
Log:
fix various test accounting bugs revealed by Test::More

Modified:
    perl/modperl/trunk/t/filter/TestFilter/in_bbs_body.pm
    perl/modperl/trunk/t/filter/in_bbs_body.t
    perl/modperl/trunk/t/response/TestAPI/sub_request.pm
    perl/modperl/trunk/t/response/TestModperl/endav.pm

Modified: perl/modperl/trunk/t/filter/TestFilter/in_bbs_body.pm
URL: http://svn.apache.org/viewcvs/perl/modperl/trunk/t/filter/TestFilter/in_bbs_body.pm?view=diff&r1=159345&r2=159346
==============================================================================
--- perl/modperl/trunk/t/filter/TestFilter/in_bbs_body.pm (original)
+++ perl/modperl/trunk/t/filter/TestFilter/in_bbs_body.pm Mon Mar 28 20:15:05 2005
@@ -46,7 +46,7 @@
         $r->puts($data);
     }
     else {
-        $r->puts("1..1\nok 1\n");
+        $r->puts("1..3\nok 1\n");
     }
 
     Apache::OK;

Modified: perl/modperl/trunk/t/filter/in_bbs_body.t
URL: http://svn.apache.org/viewcvs/perl/modperl/trunk/t/filter/in_bbs_body.t?view=diff&r1=159345&r2=159346
==============================================================================
--- perl/modperl/trunk/t/filter/in_bbs_body.t (original)
+++ perl/modperl/trunk/t/filter/in_bbs_body.t Mon Mar 28 20:15:05 2005
@@ -1,14 +1,13 @@
 use strict;
 use warnings FATAL => 'all';
 
-use Apache::Test;
 use Apache::TestRequest;
 
-plan tests => 2;
-
 my $location = '/TestFilter__in_bbs_body';
 
-for my $x (1,2) {
+print GET_BODY_ASSERT $location;
+
+for my $x (2..3) {
     my $data = scalar reverse "ok $x\n";
     print POST_BODY_ASSERT $location, content => $data;
 }

Modified: perl/modperl/trunk/t/response/TestAPI/sub_request.pm
URL: http://svn.apache.org/viewcvs/perl/modperl/trunk/t/response/TestAPI/sub_request.pm?view=diff&r1=159345&r2=159346
==============================================================================
--- perl/modperl/trunk/t/response/TestAPI/sub_request.pm (original)
+++ perl/modperl/trunk/t/response/TestAPI/sub_request.pm Mon Mar 28 20:15:05 2005
@@ -30,7 +30,7 @@
     ok t_cmp $subr->uri, $uri, "uri";
 
     my $rc = $subr->run;
-    ok $rc, Apache::SERVER_ERROR, "rc";
+    ok t_cmp $rc, Apache::SERVER_ERROR, "rc";
 
     # test an explicit DESTROY (which happens automatically on the
     # scope exit)

Modified: perl/modperl/trunk/t/response/TestModperl/endav.pm
URL: http://svn.apache.org/viewcvs/perl/modperl/trunk/t/response/TestModperl/endav.pm?view=diff&r1=159345&r2=159346
==============================================================================
--- perl/modperl/trunk/t/response/TestModperl/endav.pm (original)
+++ perl/modperl/trunk/t/response/TestModperl/endav.pm Mon Mar 28 20:15:05 2005
@@ -12,7 +12,7 @@
 sub handler {
     my $r = shift;
 
-    plan $r, test => 4;
+    plan $r, tests => 4;
 
     #just to make sure we dont segv with bogus values
     my $not = 'NoSuchPackage';